feat: add abort() method to settle pending tasks#101
Merged
Conversation
Add new abort() method that properly handles pending tasks by calling
their callbacks with an abort error and rejecting promises. This fixes
the issue where kill() left promises unsettled, causing "Detected
unsettled top-level await" warnings.
Unlike kill() which simply discards queued tasks, abort():
- Calls each queued task's callback with Error('abort')
- Rejects promises for promise-based queues
- Calls the global error handler (if set) for each aborted task
- Properly cleans up task objects and resets drain function
Fixes #97
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a new
abort()method that properly handles pending tasks by calling their callbacks with an abort error and rejecting promises. This fixes issue #97 wherekill()left promises unsettled, causing "Detected unsettled top-level await" warnings.Changes
New
abort()method inqueue.jsthat:Error('abort')TypeScript definitions updated in
index.d.tsto include the new methodComprehensive test coverage added:
test/test.jstest/promise.jsDifferences from
kill()Unlike
kill()which simply discards queued tasks:abort()calls each queued task's callback withError('abort')Test Results
Example Usage
Fixes #97
🤖 Generated with Claude Code