Skip to content

Add support for yaml config file#105

Merged
mcollina merged 2 commits into
mcollina:mainfrom
jsumners:rcfile
Oct 11, 2024
Merged

Add support for yaml config file#105
mcollina merged 2 commits into
mcollina:mainfrom
jsumners:rcfile

Conversation

@jsumners

Copy link
Copy Markdown
Contributor

WIP

@jsumners

Copy link
Copy Markdown
Contributor Author

@mcollina please approve the CI run. I need to see what happens on Windows.

@jsumners jsumners marked this pull request as ready for review October 11, 2024 10:36

@mcollina mcollina left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jsumners

Copy link
Copy Markdown
Contributor Author

Looks like #104 is needed regardless. I was hoping adding this feature would negate needing to do anything else special for Windows 😢.

@mcollina

Copy link
Copy Markdown
Owner

Should I land #104 then?

@jsumners

Copy link
Copy Markdown
Contributor Author

I think so. I can then rebase and we can rerun these tests to see if they're fixed before issuing a new release.

@jsumners

Copy link
Copy Markdown
Contributor Author

Ping for workflow run @mcollina (thanks GitHub).

@mcollina mcollina left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 2d06c47 into mcollina:main Oct 11, 2024
@jsumners

Copy link
Copy Markdown
Contributor Author

image

@jsumners jsumners deleted the rcfile branch October 12, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants