Skip to content

Conversation

@mckib2
Copy link
Owner

@mckib2 mckib2 commented Feb 2, 2021

See numpy#18295

@seberg Here's a potential test, let me know what you think. It's modeled after this Cython test for the random C API extending examples.

Please suggest improvements, or if it's acceptable then I will merge into the PR branch.

@seberg
Copy link

seberg commented Feb 2, 2021

Wow, cool! I have to admit, I do not walk into the depth of distutils, but it does seem great to me. If you want style nitpicks, I think textwrap.dedent() would make for nicer inline code than '\n'.join(...) ;)

EDIT: to be clear, I don't see why not to use this test. Although I am not sure if there are any skip needed potentially?

@mckib2
Copy link
Owner Author

mckib2 commented Feb 3, 2021

Wow, cool! I have to admit, I do not walk into the depth of distutils, but it does seem great to me. If you want style nitpicks, I think textwrap.dedent() would make for nicer inline code than '\n'.join(...) ;)

EDIT: to be clear, I don't see why not to use this test. Although I am not sure if there are any skip needed potentially?

I do like dedent better. I had to use a combination of indent/dedent to do the right thing for Fortran 77 (first 6 columns are reserved). The only skips in the numpy random C API tests are for slow (which I have) and if cython/numba/cffi are not present (which aren't used here), so I think we should be good on skips.

@mckib2 mckib2 merged commit 13603d4 into bug-fix-fake-libs Feb 3, 2021
@mckib2 mckib2 deleted the fake-libs-build-test branch February 3, 2021 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants