Skip to content

kata_agent: Set the VmPath for each mmioblk device#5

Merged
mcastelino merged 1 commit intomcastelino:topic/fc-1from
sboeuf:fix_fc_extra_mmioblk
Dec 20, 2018
Merged

kata_agent: Set the VmPath for each mmioblk device#5
mcastelino merged 1 commit intomcastelino:topic/fc-1from
sboeuf:fix_fc_extra_mmioblk

Conversation

@sboeuf
Copy link
Copy Markdown

@sboeuf sboeuf commented Dec 20, 2018

By not setting the VmPath for mmioblk devices, we prevent extra block
devices from being passed properly through the VM. In case of mmioblk,
there is no such thing as a PCI BDF, so we simply predict the name of
the device that will show up inside the VM.

By setting the VmPath field of the structure Device, we make sure the
agent receives the right information to find the device inside the VM.

Signed-off-by: Sebastien Boeuf sebastien.boeuf@intel.com

By not setting the VmPath for mmioblk devices, we prevent extra block
devices from being passed properly through the VM. In case of mmioblk,
there is no such thing as a PCI BDF, so we simply predict the name of
the device that will show up inside the VM.

By setting the VmPath field of the structure Device, we make sure the
agent receives the right information to find the device inside the VM.

Signed-off-by: Sebastien Boeuf <sebastien.boeuf@intel.com>
@sboeuf
Copy link
Copy Markdown
Author

sboeuf commented Dec 20, 2018

/cc @mcastelino @egernst

Copy link
Copy Markdown
Owner

@mcastelino mcastelino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This will not hurt.

@mcastelino mcastelino merged commit 75708f7 into mcastelino:topic/fc-1 Dec 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants