Conversation
|
Thanks the update, this is an improvement! I don't want to be difficult about such a small change, but the indentation is still changed from 4 to 2 spaces which doesn't match the rest of the code. I can change this myself before merging if you like / let me know if you'd like any help with any of this. BTW. you could have updated #1 with this change by pushing the new commit to the corresponding branch, no new PR was required. |
|
@mbg Done. An additional commit indents the new code with 4 white spaces. |
mbg
left a comment
There was a problem hiding this comment.
Thank you! That's made the diff clearer to read as well. Just one quick comment regarding TCL (see below).
| | Modula2 | ||
| | Ada | ||
| | Perl | ||
| | TCL |
There was a problem hiding this comment.
The moss website lists TCL as a supported language. Have you removed this because you tried it and it didn't work? (I note that it and HCL2 are mentioned on the website, but not in the perl script.)
There was a problem hiding this comment.
@mbg indeed, I spotted this too.
The web page includes TCL, but the perl script (as of 24 October 2019) Stanford send out does not include it:
@languages = ("c", "cc", "java", "ml", "pascal", "ada", "lisp", "scheme", "haskell", "fortran", "ascii", "vhdl", "perl", "matlab", "python", "mips", "prolog", "spice", "vb", "csharp", "modula2", "a8086", "javascript", "plsql", "verilog");
Should this Haskell moss library include TCL, or not?
There was a problem hiding this comment.
The comment in the perl script I received (6 February 2018) notes that the website should be the authoritative source for supported languages:
# As of the date this script was written, the following languages were supported. This script will work with
# languages added later however. Check the moss website for the full list of supported languages.If that's still the case in the script you received, I think it would be best to leave TCL in as I suspect that they have updated the website, but not the script whenever it was they added TCL.
|
FYI v0.2 of the library, which includes your contribution, is now live on Hackage. |
|
@mbg Thanks! FYI I'm using your moss library in a command line program That tool uses the |
|
Nice! I am glad you find the library is useful and it's seeing some usage! I originally built it around 3 years ago for a similar tool as your |
I'd be very interested in learning more about what you've developed at Warwick. Have you written about it? |
|
I haven't written about it anywhere (unfortunately), but I'd be happy to have a chat about it - feel free to send me an email with times that would work for you and we can arrange a time. |
No description provided.