User sessions plugin improvements#7
Merged
mbarto merged 3 commits intombarto:user_sessions_pluginfrom Apr 29, 2020
Merged
Conversation
Author
|
Please @mbarto can you look at this to confirm my hypothesis and review my changes? Thank you |
mbarto
reviewed
Apr 29, 2020
web/client/epics/context.js
Outdated
| const userName = userSelector(getState())?.name; | ||
| return Observable.of(loadUserSession(buildSessionName(id, mapId, userName))).merge( | ||
| action$.ofType(USER_SESSION_LOADED).flatMap(({session}) => { | ||
| action$.do(console.log).ofType(USER_SESSION_LOADED).take(1).switchMap(({session}) => { |
Owner
There was a problem hiding this comment.
Is the console.log expected, or did you forget to remove it?
mbarto
reviewed
Apr 29, 2020
Owner
mbarto
left a comment
There was a problem hiding this comment.
No concerns, have a look at my comment about console.log
mbarto
approved these changes
Apr 29, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description