Skip to content

Add optional attribute to emit event while sliding the cursor#29

Merged
maxshuty merged 1 commit intomaxshuty:masterfrom
dapicester:feature/emit-event-on-update
Oct 29, 2024
Merged

Add optional attribute to emit event while sliding the cursor#29
maxshuty merged 1 commit intomaxshuty:masterfrom
dapicester:feature/emit-event-on-update

Conversation

@dapicester
Copy link
Copy Markdown

The consumer of this component can listen for the range-changed event when the user has adjusted the ranges.

By default the event triggers only when the change has been completed, that is when the sliding movement has finished.

In some cases the consumer may want to listen for changes also while sliding the cursor, for example when using custom labels.

This is now possible by setting the emit-event-on-update attribute.

The consumer of this component can listen for the `range-changed` event
when the user has adjusted the ranges.

By default the event triggers only when the change has been completed,
that is when the sliding movement has finished.

In some cases the consumer may want to listen for changes also while
sliding the cursor, for example when using custom labels.

This is now possible by setting the `emit-event-on-update` attribute.
@maxshuty maxshuty merged commit 32ec128 into maxshuty:master Oct 29, 2024
@maxshuty
Copy link
Copy Markdown
Owner

Thank you @dapicester - and kudos for updating the README as well! It's been merged in.

@maxshuty
Copy link
Copy Markdown
Owner

@dapicester I updated the version and this is now included in v1.0.15 and you've been added to the contributors list in the README. Thanks!

@dapicester
Copy link
Copy Markdown
Author

Thanks @maxshuty. However I did realize that I had a typo. I did a last minute rename and I got the name wrong. I will submit another MR to fix that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants