fix: agent-browser ARM64 Linux support, dynamic devcontainer naming

maxritter · maxritter · commit d8baf10283af · 2026-03-30T08:42:57.000+02:00
- Installer: on Linux ARM64, install system chromium via apt instead of
  agent-browser install --with-deps (Chrome for Testing has no ARM64 builds)
- Devcontainer: add chromium to Dockerfile apt packages
- Devcontainer: use ${localWorkspaceFolderBasename} for name, runArgs,
  and workspaceFolder so it works in any project folder
- Unmark devcontainer files from assume-unchanged/skip-worktree
diff --git a/.devcontainer/Dockerfile b/.devcontainer/Dockerfile
@@ -21,6 +21,7 @@ RUN rm -rf /var/lib/apt/lists/* && \
         jq \
         vim \
         netcat-openbsd \
-        socat && \
+        socat \
+        chromium && \
     apt-get clean && \
     rm -rf /var/lib/apt/lists/*
diff --git a/.devcontainer/devcontainer.json b/.devcontainer/devcontainer.json
@@ -1,13 +1,13 @@
 {
-  "name": "pilot-shell",
+  "name": "${localWorkspaceFolderBasename}",
   "build": {
     "dockerfile": "Dockerfile"
   },
   "runArgs": [
     "--name",
-    "pilot-shell"
+    "${localWorkspaceFolderBasename}"
   ],
-  "workspaceFolder": "/workspaces/pilot-shell",
+  "workspaceFolder": "/workspaces/${localWorkspaceFolderBasename}",
   "customizations": {
     "vscode": {
       "extensions": [
diff --git a/installer/steps/dependencies.py b/installer/steps/dependencies.py
@@ -11,7 +11,7 @@
 from typing import Any
 
 from installer.context import InstallContext
-from installer.platform_utils import command_exists, npm_global_cmd
+from installer.platform_utils import command_exists, is_linux_arm64, npm_global_cmd
 from installer.steps.base import BaseStep
 
 MAX_RETRIES = 3
@@ -385,17 +385,24 @@ def _is_agent_browser_ready() -> bool:
 def install_agent_browser() -> bool:
     """Install agent-browser for headless browser automation.
 
-    On Linux, installs with --with-deps for system dependencies.
+    On Linux ARM64, Chrome for Testing has no builds — install system chromium
+    via apt instead. On other Linux, use --with-deps. On macOS, plain install.
     """
-    import platform
-
     if _is_agent_browser_ready():
-        _run_bash_with_retry("agent-browser upgrade", timeout=120)  # best-effort; failure is non-fatal — existing version still works
+        _run_bash_with_retry("agent-browser upgrade", timeout=120)  # best-effort
         return True
 
     if not _run_bash_with_retry(npm_global_cmd("npm install -g agent-browser")):
         return False
 
+    if is_linux_arm64():
+        # Chrome for Testing doesn't provide ARM64 Linux builds.
+        # Install system chromium instead — agent-browser auto-detects it.
+        _run_bash_with_retry("apt-get update -qq && apt-get install -y -qq chromium", timeout=180)
+        return True
+
+    import platform
+
     install_cmd = "agent-browser install --with-deps" if platform.system() == "Linux" else "agent-browser install"
     return _run_bash_with_retry(install_cmd, timeout=300)
 
diff --git a/installer/tests/unit/steps/test_dependencies_playwright.py b/installer/tests/unit/steps/test_dependencies_playwright.py
@@ -68,10 +68,11 @@ def test_upgrades_when_already_ready(self, mock_ready, mock_run):
         mock_run.assert_called_once_with("agent-browser upgrade", timeout=120)
 
     @patch("platform.system", return_value="Darwin")
+    @patch("installer.steps.dependencies.is_linux_arm64", return_value=False)
     @patch("installer.steps.dependencies.npm_global_cmd", side_effect=lambda x: x)
     @patch("installer.steps.dependencies._run_bash_with_retry")
     @patch("installer.steps.dependencies._is_agent_browser_ready")
-    def test_installs_npm_package_and_chrome_macos(self, mock_ready, mock_run, _mock_npm, _mock_system):
+    def test_installs_npm_package_and_chrome_macos(self, mock_ready, mock_run, _mock_npm, _mock_arm, _mock_system):
         """Installs agent-browser via npm then runs install on macOS."""
         from installer.steps.dependencies import install_agent_browser
 
@@ -83,18 +84,32 @@ def test_installs_npm_package_and_chrome_macos(self, mock_ready, mock_run, _mock
         mock_run.assert_any_call("agent-browser install", timeout=300)
 
     @patch("platform.system", return_value="Linux")
+    @patch("installer.steps.dependencies.is_linux_arm64", return_value=False)
     @patch("installer.steps.dependencies.npm_global_cmd", side_effect=lambda x: x)
     @patch("installer.steps.dependencies._run_bash_with_retry")
     @patch("installer.steps.dependencies._is_agent_browser_ready")
-    def test_installs_with_deps_on_linux(self, mock_ready, mock_run, _mock_npm, _mock_system):
-        """Installs with --with-deps on Linux for system dependencies."""
+    def test_installs_with_deps_on_linux_x86(self, mock_ready, mock_run, _mock_npm, _mock_arm, _mock_system):
+        """Installs with --with-deps on Linux x86_64."""
         from installer.steps.dependencies import install_agent_browser
 
         mock_ready.return_value = False
         mock_run.return_value = True
         assert install_agent_browser() is True
         mock_run.assert_any_call("agent-browser install --with-deps", timeout=300)
 
+    @patch("installer.steps.dependencies.is_linux_arm64", return_value=True)
+    @patch("installer.steps.dependencies.npm_global_cmd", side_effect=lambda x: x)
+    @patch("installer.steps.dependencies._run_bash_with_retry")
+    @patch("installer.steps.dependencies._is_agent_browser_ready")
+    def test_installs_chromium_apt_on_linux_arm64(self, mock_ready, mock_run, _mock_npm, _mock_arm):
+        """Installs system chromium via apt on Linux ARM64."""
+        from installer.steps.dependencies import install_agent_browser
+
+        mock_ready.return_value = False
+        mock_run.return_value = True
+        assert install_agent_browser() is True
+        mock_run.assert_any_call("apt-get update -qq && apt-get install -y -qq chromium", timeout=180)
+
     @patch("installer.steps.dependencies._is_agent_browser_ready")
     @patch("installer.steps.dependencies._run_bash_with_retry")
     def test_returns_false_when_npm_fails(self, mock_run, mock_ready):
