Merged
Conversation
Just a suggestion - but feel free to ignore it, as you may have done this for a reason. But, maybe check if ACF is active via the class name; as some people put ACF in the must-use folder (or vendor folder), which is ignored by 'is_plugin_active'.
Owner
|
Thank you alexwoollam for your very correct PR. I keep it aside. As soon as I have a moment to dedicate to the extension, I merge. Thanks a lot. I take this opportunity to ask you if you use this extension, and if so for what ? |
Owner
|
Thank you @alexwoollam for PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just a suggestion - but feel free to ignore it, as you may have done this for a reason.
But, maybe check if ACF is active via the class name; as some people put ACF in the must-use folder (or vendor folder),
which is ignored by 'is_plugin_active'.