Skip to content

GeoIp2Provider doesn't define insights methods #359

@echrisinger

Description

@echrisinger

Love that you guys package a great client lib. Thanks for the hard work.

One thing that would be useful would be including the insights methods on GeoIp2Provider, or another interface; this makes providing a test double for insights much more easily, as you don't have to wrap WebServiceClient to return a predictable response. We prefer to do this to avoid introducing the complexity of mocking frameworks.

Thanks!
Evan

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions