Conversation
This commit introduces proxy support for Reddit requests within the ASFFreeGames plugin, addressing issues #75 #76. Users can now configure proxies for both general and Reddit-specific connections through the Proxy and RedditProxy settings in ASFFreeGamesOptions.cs. Key changes: - ASFFreeGamesOptions.cs: Added properties Proxy and RedditProxy to support proxy configuration for general and Reddit connections respectively. - ASFFreeGamesOptionsLoader.cs: Updated to load proxy settings from configuration and environment variables. - FreeGamesCommand.cs: Modified GetGames to utilize SimpleHttpClientFactory and its CreateForReddit method, enabling the use of the configured Reddit proxy. - RedditHelper.cs: Replaced WebBrowser usage with SimpleHttpClient for Reddit communication, allowing proxy support. These improvements enhance the plugin's flexibility by allowing users to leverage proxy servers for Reddit interactions.
…limiting from Reddit. * Added checks for remaining rate limit and reset time to implement appropriate delays based on Reddit's response headers.
GetStreamAsync() internal request object use configured http version
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request implements proxy support for Reddit requests within the ASFFreeGames plugin, addressing issues #75 and #76.
Users can now leverage proxies Reddit.com api specific connections, increasing flexibility for those utilizing proxy servers for Reddit interactions.
Changes:
New configuration options:
ASFFreeGamesOptions.cs: Added propertiesProxyandRedditProxyto support proxy configuration for general and Reddit connections, respectively.ASFFreeGamesOptionsLoader.cs: Updated to load proxy settings from configuration and environment variables. These settings are then merged to ensure all configurations are considered.Refactored Reddit communication:
GetGamesto utilizeSimpleHttpClientFactoryand itsCreateForRedditmethod, enabling the use of the configured Reddit proxy.WebBrowserusage withSimpleHttpClientfor Reddit communication, allowing proxy support.Benefits:
SimpleHttpClientconsistently.Disclaimers/Bugs/Issues:
System.MissingMethodException: This change might introduce the possibility of encounteringSystem.MissingMethodExceptionerrors in future ASF updates. Thorough testing and potential code updates may be required to mitigate this risk.Testing:
Additional Notes:
TO-DOs: