Conversation
…r resiliency (fix #99) Change HttpClientHandler to SocketsHttpHandler to match ArchiSteamFarm upstream code This commit addresses the issue raised in #99 by using reflection to set properties on `SocketsHttpHandler` and `HttpClient`. This ensures that our code continues to function even if the property names are changed in a future trimmed binary. **Changes:** * Modified `SimpleHttpClient` constructor to use reflection-based property setting for: * `AutomaticDecompression` * `MaxConnectionsPerServer` * `EnableMultipleHttp2Connections` * Added a new helper method `SetPropertyValue` for generic property access with logging. * Updated `SetExpectContinueProperty` to use reflection as well. * Introduced a new method `SetPropertyWithLogging` to handle potential exceptions and log warnings if property access fails. * Updated `Directory.Build.props` to increment the version to `1.7.1.0`. **Additional Notes:** * Reflection can be slightly slower than direct property access. However, this approach offers greater flexibility and resilience to potential changes in the underlying libraries. **This commit is related to issue #99.**
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use SocketsHttpHandler & Implement property access with reflection for resiliency (fix #99)
Change HttpClientHandler to SocketsHttpHandler to match ArchiSteamFarm upstream code This commit addresses the issue raised in #99 by using reflection to set properties on
SocketsHttpHandlerandHttpClient. This ensures that our code continues to function even if the property names are changed or deleted in a future trimmed binary.Changes:
SimpleHttpClientconstructor to use reflection-based property setting for:AutomaticDecompressionMaxConnectionsPerServerEnableMultipleHttp2ConnectionsSetPropertyValuefor generic property access with logging.SetExpectContinuePropertyto use reflection as well.SetPropertyWithLoggingto handle potential exceptions and log warnings if property access fails.Directory.Build.propsto increment the version to1.7.1.0.Additional Notes:
This commit is related to issue #99.