Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: maxisoft/ASFFreeGames
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.8.1
Choose a base ref
...
head repository: maxisoft/ASFFreeGames
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.9.0
Choose a head ref
  • 18 commits
  • 39 files changed
  • 3 contributors

Commits on Dec 4, 2024

  1. Merge pull request #111 from maxisoft/dev

    Fix various missing method or class loading due to ASF update
    maxisoft authored Dec 4, 2024
    Configuration menu
    Copy the full SHA
    c2d017e View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2024

  1. Configuration menu
    Copy the full SHA
    cbe45f9 View commit details
    Browse the repository at this point in the history

Commits on Jan 2, 2025

  1. Configuration menu
    Copy the full SHA
    cc8ada2 View commit details
    Browse the repository at this point in the history

Commits on Feb 3, 2025

  1. Configuration menu
    Copy the full SHA
    9058d1f View commit details
    Browse the repository at this point in the history

Commits on Feb 4, 2025

  1. Configuration menu
    Copy the full SHA
    8ad6d88 View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2025

  1. Configuration menu
    Copy the full SHA
    58df410 View commit details
    Browse the repository at this point in the history
  2. Fix submodule path and update resource folder name; remove outdated r…

    …edlib_instances.json and add new version
    peter9811 committed Feb 23, 2025
    Configuration menu
    Copy the full SHA
    f925578 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    1d5eb9c View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    5e4fe10 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    cfeb1c2 View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2025

  1. Configuration menu
    Copy the full SHA
    9ca5a69 View commit details
    Browse the repository at this point in the history

Commits on Mar 2, 2025

  1. Configuration menu
    Copy the full SHA
    cd1bb18 View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2025

  1. feat: Upgrade to .NET 9.0 and update dependencies

    Migrates the project to .NET 9.0 and updates core dependencies.
    
    This includes:
    - Upgrading target frameworks and SDK versions to .NET 9.0
    - Updating NuGet dependencies to latest versions (NLog, xunit, coverlet, Microsoft.NET.Test.Sdk, ConfigureAwaitChecker.Analyzer)
    - Bumping plugin version to 1.9.0.0
    - Minor fix in `SimpleHttpClient.DisposeAsync` for `ValueTask` handling
    - Qualifying `OrderedDictionary` namespace in Reddit components for clarity
    - Adapting `BotContext` for robust `Bot.OwnedPackages` access, using reflection for fallback
    
    This upgrade ensures compatibility with the latest .NET runtime and incorporates recent improvements from dependency updates.
    maxisoft committed Mar 6, 2025
    Configuration menu
    Copy the full SHA
    9a27839 View commit details
    Browse the repository at this point in the history
  2. Merge remote-tracking branch 'remotes/peter9811-remote/main' into dev

    Improve README clarity, update submodule references, and fix namespace spelling.
    
    This commit addresses several issues raised in #121:
    
    *   Enhanced the README for better understanding and improved formatting.
    *   Corrected the submodule path and updated the resource folder name.
    *   Updated the ArchiSteamFarm subproject to the latest commit.  (Note: This submodule was previously reported as 404, this commit should resolve this.)
    *   Fixed the namespace spelling from 'ASFExtentions' to 'ASFExtensions'.
    *   Added VSCode settings to ignore pull request branches from main.
    *   Improved error handling in CollectGamesOnClock method for scheduled free games.
    
    Conflicts in .gitmodules and ArchiSteamFarm were resolved.
    ---
    The pull request primarily focuses on:
    
    * **Namespace Corrections:**  Changing `ASFExtentions` to `ASFExtensions` throughout the codebase. This appears to be a correction of a consistent typo.
    * **Code Style and Formatting:** Minor formatting adjustments in various files, including whitespace and XML formatting.
    * **Documentation Improvements:**  Spelling and grammar corrections in comments and the README.md file, along with clarifications and updates to the documentation.
    * **Resource Folder Renaming:** Renaming the `Resouces` folder to `Resources` in the project file and code. This seems to be another typo correction.
    * **VSCode Settings:** Adding a `.vscode/settings.json` file for development environment configuration, specifically to ignore pull requests from the "main" branch in the GitHub Pull Requests extension.
    * **Minor Bug Fix/Improvement in `ASFFreeGamesPlugin.cs`:**
        * Correcting the bot instance passed to `OnBotCommand` in the scheduled task from `null!` to `reorderedBots[0]`.
        * Adding a try-catch block to handle potential exceptions during scheduled free game collection.
    * **Redlib Instance List Update:** Adding a new `Resources/redlib_instances.json` file, which seems to be an updated list of Redlib instances.
    
    **File-by-File Analysis:**
    
    * **`.gitignore`**:  Spelling correction in comments ("checkin" to "check in"). **Safe and intended.**
    * **`.vscode/settings.json`**:  VSCode specific settings, ignoring "main" branch PRs. **Safe and development-related.**
    * **`ASFFreeGames.Tests/GameIdentifierParserTests.cs` & `ASFFreeGames.Tests/GameIdentifierTests.cs`**: Namespace correction (`ASFExtentions` to `ASFExtensions`). **Safe and likely a typo fix.**
    * **`ASFFreeGames.sln`**:  Minor formatting change (removing a blank line). **Safe and cosmetic.**
    * **`ASFFreeGames/ASFExtentions/Bot`, `ASFFreeGames/ASFExtentions/Games`, `ASFFreeGames/AppLists`, `ASFFreeGames/Commands`, `ASFFreeGames/Configurations`, `ASFFreeGames/ContextRegistry`, `ASFFreeGames/Redlib`, `ASFFreeGames/Utils`**:  Consistent namespace corrections (`ASFExtentions` to `ASFExtensions`). **Safe and likely typo fixes throughout the project.**
    * **`ASFFreeGames/ASFFreeGames.csproj`**: Folder name correction (`Resouces` to `Resources`). **Safe and likely a typo fix. Ensure the folder is renamed accordingly in the filesystem if merging.**
    * **`ASFFreeGames/ASFFreeGames.csproj.DotSettings`**: Minor XML formatting change. **Safe and cosmetic.**
    * **`ASFFreeGames/ASFFreeGamesPlugin.cs`**:
        * Namespace corrections.
        * Corrected bot instance in scheduled task (`null!` to `reorderedBots[0]`). **Bug fix.**
        * Added try-catch for scheduled task. **Improvement - error handling.**
        * Removed unnecessary `#pragma warning disable/restore` which is good, likely the code is now correct async.
    * **`ASFFreeGames/Redlib/Instances/RedlibInstanceList.cs`**:
        * Resource path correction (`Resouces` to `Resources`).
        * Code style improvements.
        * Constructor parameter change (field assignment). **Refactoring, safe.**
        * Using `new List<Uri>()` instead of `[]` when instances are null. **Minor improvement in code clarity.**
    * **`ASFFreeGames/Resources/redlib_instances.json`**: New file containing a list of Redlib instances. **Likely an intended update to the default instance list. Review the URLs to ensure they are trustworthy.**
    * **`ASFFreeGames/Utils/LoggerFilter.cs` & `ASFFreeGames/Utils/RandomUtils.cs`**: Code style, formatting, documentation improvements, and minor variable name changes. **Safe and improves code quality.**
    * **`README.md`**: Documentation improvements, spelling/grammar fixes, command clarifications, proxy setup, and FAQ updates. **Safe and beneficial for users.**
    maxisoft committed Mar 6, 2025
    Configuration menu
    Copy the full SHA
    e064eac View commit details
    Browse the repository at this point in the history
  3. Allow OnBotCommand to be called without a bot instance

    The `bot` parameter in `OnBotCommand` is now nullable (`Bot? bot`), allowing the function to be called without specifying a bot.  This is necessary for scenarios like scheduled free game collection where a specific bot context might not be relevant. The call to `OnBotCommand` in `CollectScheduledFreeGames` has been updated to pass `null` for the bot parameter.
    maxisoft committed Mar 6, 2025
    Configuration menu
    Copy the full SHA
    16e07ab View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    44e8dd8 View commit details
    Browse the repository at this point in the history
  5. Introduce BotPackageChecker for resilient and performant ASF bot pack…

    …age ownership checks.
    
    This includes:
    - Direct access and reflection fallback for robustness.
    - Caching with hot-reload awareness for performance.
    - Integration into BotContext for improved ownership checks.
    - Cache clearing on bot disconnect in ASFFreeGamesPlugin.
    
    Improves reliability
    maxisoft committed Mar 6, 2025
    Configuration menu
    Copy the full SHA
    8603062 View commit details
    Browse the repository at this point in the history
  6. Merge pull request #124 from maxisoft/dev

    Refactor & Enhancements: Namespace Fix, .NET 9 Upgrade, Bot Package Checker, and Plugin Improvements
    maxisoft authored Mar 6, 2025
    Configuration menu
    Copy the full SHA
    c9d3c47 View commit details
    Browse the repository at this point in the history
Loading