Keep all legacy names in PROPS dictionary#1
Merged
maxfrei750 merged 1 commit intomaxfrei750:region_props_renamingfrom May 14, 2021
Merged
Conversation
fix mistake made during merge from main branch in __getattr__ add comment on PROPS dictionary purpose
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR keeps all legacy names in the PROPS dictionary. No existing keys are renamed and any newly deprecated names have a new key inserted.
As a single, concrete example:
'LocalCentroid': 'centroid_local', 'local_centroid': 'centroid_local',Here
LocalCentroidwas the property name in old scikit-image <= 0.8 andlocal_centroidis the current property name we want to modify. In both cases, the value should be the new, documented property name:centroid_local. Users should be able to use any of the 3 names to get this property.Checklist
./doc/examples(new features only)./benchmarks, if your changes aren't covered by anexisting benchmark
For reviewers
later.
__init__.py.doc/release/release_dev.rst.