Skip to content

Keep all legacy names in PROPS dictionary#1

Merged
maxfrei750 merged 1 commit intomaxfrei750:region_props_renamingfrom
grlee77:region_props_renaming_v2
May 14, 2021
Merged

Keep all legacy names in PROPS dictionary#1
maxfrei750 merged 1 commit intomaxfrei750:region_props_renamingfrom
grlee77:region_props_renaming_v2

Conversation

@grlee77
Copy link
Copy Markdown

@grlee77 grlee77 commented May 10, 2021

Description

This PR keeps all legacy names in the PROPS dictionary. No existing keys are renamed and any newly deprecated names have a new key inserted.

As a single, concrete example:

'LocalCentroid': 'centroid_local', 'local_centroid': 'centroid_local',
Here LocalCentroid was the property name in old scikit-image <= 0.8 and local_centroid is the current property name we want to modify. In both cases, the value should be the new, documented property name: centroid_local. Users should be able to use any of the 3 names to get this property.

Checklist

For reviewers

  • Check that the PR title is short, concise, and will make sense 1 year
    later.
  • Check that new functions are imported in corresponding __init__.py.
  • Check that new features, API changes, and deprecations are mentioned in
    doc/release/release_dev.rst.

fix mistake made during merge from main branch in __getattr__

add comment on PROPS dictionary purpose
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants