Skip to content

Conversation

@tbouffard
Copy link
Member

@tbouffard tbouffard commented Apr 25, 2025

The overall size of the all examples decreases:

  • use BaseGraph to control the default styles that are registered
  • use EdgeMarker instead of the duplicated implementation in the example

In addition:

  • use the CellEditorHandler plugin that was missing in the list of declared plugins.
  • remove ts-ignore that are no longer generated when calling the maxGraph API

Notes

Covers maxGraph/maxGraph#760

Bundle sizes

Note

The usage of BaseGraph greatly decreases the size of the examples.
Notice that the usage of the CellEditorHandler plugin increases the size significantly. In the vite example: 371.59 kB (12.5 kB)

Example previous now
farm 454.2 kB (2 files) 407.77 kB (5 files)
lit with vite 462.4 kB 402.71 kB
parcel 529.3 KB 506.47 kB
rollup 439.2 kB 380.99 kB
rsbuild 416.9 kB 358.0 kB
vite 443.1 kB 384.02 kB

Contents

The overall size of the all examples decreases:
  - use `BaseGraph` to control the default styles that are registered
  - use `EdgeMarker` instead of the duplicated implementation in the example

In addition:
  - use the `CellEditorHandler` plugin that was missing in the list of declared plugins.
  - remove ts-ignore that are no longer generated when calling the maxGraph API
@sonarqubecloud
Copy link

@tbouffard tbouffard marked this pull request as ready for review April 26, 2025 16:00
@tbouffard tbouffard merged commit 5004cec into main Apr 26, 2025
18 checks passed
@tbouffard tbouffard deleted the feat/use_BaseGraph branch April 26, 2025 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant