refactor: clean the Client class #94
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove unused static properties - mxForceIncludes: it was used to force loading the JavaScript files in development mode in mxGraph. We are not managing development mode in that way anymore. - mxLoadResource: not used anymore - mxLoadStylesheets: not used anymore - mxResourceExtension: it was only used in Translations, so only keep the Translations settings Move and rename the link function. It is not a general function, so move it as `domUtils#addLinkToHead` Fix documentation of static properties
b111272 to
2c3b888
Compare
junsikshim
approved these changes
Jul 16, 2022
Collaborator
junsikshim
left a comment
There was a problem hiding this comment.
It's nice to see that Client cleaned up. It was quite a mess.
Just FYI, I recently moved to a new company, and have been spending much time adjusting to a new environment. I'll try to contribute as soon as possible. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Remove unused static properties
managing development mode in that way anymore.
Move and rename the link function. It is not a general function, so move it as
domUtils#addLinkToHeadFix documentation of static properties
Other info
In the future, I suggest we move all languages related properties from Client to Translations. This is the place where they belong and this will improve tree-shaking for people that don't rely on the Translations features.