Skip to content

Conversation

@tbouffard
Copy link
Member

@tbouffard tbouffard commented Jun 10, 2022

Summary

The README is the main entry point of the lib. It should provide the main information about the project and should attract potential users.
Currently, as noticed by @mcyph in #85 (comment) is a mix of technical information and outdated sentences about the good old mxGraph.

This Pull Request is a first attempt to improve things. In short

  • First present what the lib does and the project status.
  • Then, provide a code example and a gif to let potential users see the rendering at a glance.
  • Remove inaccurate content and refresh the project history.

I am sure that the layout and the style can be improved, but IMHO, it is a good start that we will able to improve iteratively later.

Description for the changelog

doc: explain what maxGraph does an the project status in the README

Other info

Since I am not a native English speaker, I would be happy if someone could improve the wording 😸 .

This contribution is done under the terms of the Apache 2.0 license as stated in https://www.apache.org/licenses/LICENSE-2.0.

…o use it

First present what the lib does and the project status.
Provide a code example and a gif to let potential users see the rendering at a glance.
Remove inaccurate content and refresh the project history.
@tbouffard tbouffard added the documentation Improvements or additions to documentation label Jun 10, 2022
@tbouffard tbouffard requested review from junsikshim and mcyph June 10, 2022 13:37
// Adds cells to the model in a single step
graph.batchUpdate(() => {
const vertex01 = graph.insertVertex(parent, null, 'a regular rectangle', 10, 10, 100, 100);
const vertex02 = graph.insertVertex(parent, null, 'a regular ellipse', 350, 90, 50, 50, <CellStyle>{shape: 'ellipse', fillColor: 'orange'});
Copy link
Member Author

@tbouffard tbouffard Jun 10, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ℹ️ the method signature in the type is currently: insertVertex: (...args: any[]) => Cell;
So, cast to CellStyle to get code assist.

@mcyph
Copy link
Collaborator

mcyph commented Jun 11, 2022

A good start, would like to add something which states what mxGraph/maxGraph does too. Putting this together on the train but will revise this later:

maxGraph is a TypeScript library which can display and allow interaction with vector diagrams. At a high level, it provides:

  • Nodes, also known as vertices which are typically represented by shapes like rectangles.
  • Edges which can be lines and arrows which normally point between one node and another.

It provides many of the diagramming features which would be expected by a piece of presentation software like Microsoft® PowerPoint™ or LibreOffice® Impress such as being able to resize, move or rotate nodes, but has a stronger focus on automatic layout algorithms and applications of Graph Theory. It is suited towards software which requires finer-grained customization of functionality than off-the-shelf packages.

Let me know if the above sounds ok to you, or if it could be improved. I think the wording could be made smoother.

@tbouffard
Copy link
Member Author

Let me know if the above sounds ok to you, or if it could be improved. I think the wording could be made smoother.

I like the idea to have a more detailed description of the lib and your proposal sounds good to me 💯
I will read it again next week with fresh eyes and see if it has to be improved. Otherwise let's go for it!

@tbouffard
Copy link
Member Author

@mcyph I have integrated in the README the proposal you made in #93 (comment)
I also did additional improvements in other paragraphs.

@tbouffard tbouffard mentioned this pull request Jun 27, 2022
@tbouffard
Copy link
Member Author

I am going to merge this PR: it is much more accurate than the current one and it can be improved later.

@tbouffard tbouffard changed the title doc: explain what maxGraph does an the project status in the README doc: explain the maxGraph mission and status in the README Jul 4, 2022
@tbouffard tbouffard merged commit 6180434 into development Jul 4, 2022
@tbouffard tbouffard deleted the doc/improve_readme branch July 4, 2022 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants