refactor: simplify signature of the isNullish internal function #907
Conversation
Use a single type for the input parameter and declare the returned type explicitly.
WalkthroughConverted the exported Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 💡 Knowledge Base configuration:
You can enable these sources in your CodeRabbit configuration. 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
packages/core/src/internal/utils.ts (1)
37-42: Clarify JSDoc: this checks only null/undefined (not other falsy values).Current wording suggests it handles falsy values too and uses “objects” inaccurately. Tighten the doc to prevent misuse.
-/** - * Use this function to check for null or undefined values for objects having falsy values in addition to nullish values: - * - * - boolean (false) - * - number (0) - * - string (empty) - * - * @private not part of the public API, can be removed or changed without prior notice - */ +/** + * Returns true if the input is null or undefined. + * Note: falsy-but-defined values (false, 0, '') are NOT considered nullish. + * Use this when you must allow falsy values but reject absent ones. + * + * @private not part of the public API, can be removed or changed without prior notice + */
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
packages/core/src/internal/utils.ts(1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📓 Common learnings
Learnt from: tbouffard
PR: maxGraph/maxGraph#849
File: packages/html/stories/DragSource.stories.js:98-101
Timestamp: 2025-06-13T07:48:10.300Z
Learning: User tbouffard prefers answers in English; avoid switching to other languages in future replies.
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: build
- GitHub Check: build (macos-14)
- GitHub Check: build (ubuntu-24.04)
- GitHub Check: build (windows-2022)
🔇 Additional comments (1)
packages/core/src/internal/utils.ts (1)
45-46: isNullish type-guard usage verified – safe to mergeAll scans across
.ts/.tsxfiles for array callbacks (filter,some,every,find), boolean‐typed function assignments, and re-exports returned no matches. There are no breaking usages introduced by this change. Merge away!
|
Use a single type for the input parameter and declare the returned type explicitly.
Summary by CodeRabbit