Skip to content

Conversation

@tbouffard
Copy link
Member

See discussions in #35

cc @lalicw

@tbouffard tbouffard requested review from junsikshim and mcyph May 7, 2022 15:58
@mcyph
Copy link
Collaborator

mcyph commented May 8, 2022

@tbouffard @tbouffard This is a good step forwards, but note there were some examples which were under the new license that will need to be reverted to the revision before the change away from the Apache license.

I think it'd be a good idea to change the notices I added in each source file to say something like "Converted to TypeScript and maintained by the maxGraph project. See also CONTRIBUTORS.md for more info". I originally put some notices saying I made modifications to be in line with the 4b section of the Apache license ("You must cause any modified files to carry prominent notices stating that You changed the files;") but I think it could be best to remove these and put who has made which changes in a different file.

(Sorry for not being active lately btw - haven't been working on any projects in last month or two. Started working to convert the styles to objects a few times but didn't follow through. @junsikshim I think your changes are pretty similar to what I had in mind and are likely some of the last major things needed before a release. I'd like to do some documentation-related things explaining what maxGraph does on the front page if I have time. Some people I referred this project to didn't immediately understand possible use cases for this library before I explained to them based on the current README.md, and think it could be good to put a description of the project at the top of this page possibly together with a hosted storybook instance to show its capabilities. But otherwise I think the current state of the code looks very good and probably close to release, maybe with the exception of the serialization stuff.)

@tbouffard tbouffard marked this pull request as draft May 8, 2022 16:44
@tbouffard
Copy link
Member Author

Putting back to Draft until we consider the updates proposed by #85 (comment)

@mcyph mcyph mentioned this pull request Jun 4, 2022
14 tasks
@tbouffard tbouffard closed this Jun 4, 2022
@tbouffard
Copy link
Member Author

Closed because a much larger plan is decided. See #89

@tbouffard tbouffard deleted the chore/license_apache2 branch June 10, 2022 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants