Reviewing files that changed from the base of the PR and between 4d7448d and 81a028a.

• CHANGELOG.md (1 hunks)
• packages/core/src/gui/MaxWindow.ts (2 hunks)
• packages/core/src/internal/utils.ts (2 hunks)
• packages/core/src/util/Constants.ts (1 hunks)
• packages/core/src/util/StringUtils.ts (2 hunks)
• packages/core/src/util/domUtils.ts (2 hunks)
• packages/core/src/util/xmlUtils.ts (4 hunks)
• packages/core/src/view/geometry/stencil/StencilShapeRegistry.ts (1 hunks)
• packages/html/stories/shared/utils.ts (1 hunks)
• packages/ts-example-selected-features/vite.config.js (1 hunks)
• packages/ts-example/vite.config.js (1 hunks)

• GitHub Check: build
• GitHub Check: build (macos-14)
• GitHub Check: build (windows-2022)
• GitHub Check: build (ubuntu-22.04)

packages/ts-example-selected-features/vite.config.js (1)

30-30: Adjusted chunk size warning threshold to match new bundle size.

The chunkSizeWarningLimit has been decreased from 378 to 377, likely reflecting the reduced bundle size from replacing the NODETYPE enum with the NODE_TYPE value object.

packages/ts-example/vite.config.js (1)

30-30: Adjusted chunk size warning threshold to match new bundle size.

The chunkSizeWarningLimit has been decreased from 436 to 435, corresponding to the reduced bundle size achieved by replacing the NODETYPE enum with the NODE_TYPE value object.

packages/core/src/util/Constants.ts (1)

426-443:

Details

✅ Verification successful

New NODE_TYPE constant object follows modern TypeScript patterns.

The new NODE_TYPE constant object properly replaces the previous NODETYPE enum, providing the same functionality with better tree-shaking potential. The use of as const ensures type safety and immutability, while the naming convention using uppercase with underscores is consistent with other constants in the file.

The renaming of DOCUMENTTYPE to DOCUMENT_TYPE improves naming consistency.

Let's verify that all references to the old enum have been properly updated:

---

🏁 Script executed:

#!/bin/bash
# Check for any remaining references to the old NODETYPE enum
echo "Checking for remaining references to NODETYPE..."
rg "NODETYPE" --type ts

# Check for proper usage of the new NODE_TYPE constant
echo "Checking usage of new NODE_TYPE constant..."
rg "NODE_TYPE\." --type ts

Length of output: 1440

---

All old NODETYPE references removed – changes approved.

I searched the codebase and found no lingering references to the old NODETYPE enum, and confirmed that all usages now reference the new NODE_TYPE constant. No further action is required.

CHANGELOG.md (1)

24-25: Well-documented breaking change in the changelog.

The breaking change has been properly documented in the changelog, clearly stating that:

1. The constants.NODETYPE enum has been removed and replaced by the constants.NODE_TYPE value object
2. The enum member DOCUMENTTYPE has been renamed to DOCUMENT_TYPE

This provides users with clear migration instructions when updating to the new version.

packages/core/src/view/geometry/stencil/StencilShapeRegistry.ts (1)

35-35: Code example correctly updated to use new naming convention.

The example in the documentation comment has been properly updated to use constants.NODE_TYPE.ELEMENT instead of the old constants.NODETYPE.ELEMENT enum, aligning with the codebase-wide refactoring.

packages/core/src/internal/utils.ts (2)

17-17: Import statement correctly updated.

The import statement has been properly updated to use the new NODE_TYPE constant object instead of the deprecated NODETYPE enum.

---

34-34: Node type check correctly updated.

The node type check in the isElement function has been properly updated to use NODE_TYPE.ELEMENT instead of NODETYPE.ELEMENT, consistent with the codebase-wide refactoring.

packages/core/src/util/StringUtils.ts (2)

17-17: Import statement correctly updated.

The import statement has been properly updated to use the new NODE_TYPE constant object instead of the deprecated NODETYPE enum.

---

119-119: Node type check correctly updated.

The node type check in the removeWhitespace function has been properly updated to use NODE_TYPE.TEXT instead of NODETYPE.TEXT, consistent with the codebase-wide refactoring.

packages/core/src/util/xmlUtils.ts (2)

19-19: Import statement correctly updated.

The import statement has been properly updated to use the new NODE_TYPE constant object instead of the deprecated NODETYPE enum.

---

150-150: All node type comparisons correctly updated.

All node type comparisons in the getPrettyXml function have been properly updated to use the new NODE_TYPE constant object instead of the deprecated NODETYPE enum. This includes checks for document, document fragment, comment, text, and CDATA node types.

Also applies to: 160-160, 169-169, 175-175, 181-181

packages/core/src/gui/MaxWindow.ts (2)

25-25: Import statement correctly updated.

The import statement has been properly updated to use the new NODE_TYPE constant object instead of the deprecated NODETYPE enum.

---

374-374: Node type check correctly updated.

The node type check in the setTitle method has been properly updated to use NODE_TYPE.TEXT instead of NODETYPE.TEXT, consistent with the codebase-wide refactoring.

packages/html/stories/shared/utils.ts (1)

20-20: Replace NODETYPE reference with new NODE_TYPE constant
The condition now correctly checks constants.NODE_TYPE.ELEMENT against node.nodeType, aligning with the refactored value object in Constants.ts.

packages/core/src/util/domUtils.ts (3)

17-17: Update import to use NODE_TYPE
The import has been updated from the deprecated NODETYPE enum to the new readonly NODE_TYPE object, ensuring consistency with the definition in Constants.ts.

---

265-265: Correct JSDoc to reference NODE_TYPE
The @param annotation now links to NODE_TYPE.ELEMENT instead of the old enum, keeping the documentation accurate and in sync with the code.

---

269-269: Set default parameter to NODE_TYPE.ELEMENT
Defining nodeType: number = NODE_TYPE.ELEMENT simplifies the function signature and removes ambiguity when callers omit this argument.