chore: GitHub workflow generates TypeScript declarations #80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures we don't have type errors in the code.
junsikshim
approved these changes
Feb 21, 2022
Member
Author
|
The build is now able to detect type issues and the development branch is now fixed. |
Previous configuration prevented to run the type generation twice The generated d.ts files were considered as source files, so we got file override errors.
We cannot call directly tsc or lerna command in macOS GH actions runner, so introduce the script.
Member
Author
|
I have just make the type checks command work on macOS. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures we don't have type errors in the code.
Notes
The development branch currently contains type errors that will be fixed by #78. So the first commit of this Pull Request will fail.
Once it will be merged, the build should be OK.