chore: fix build error and introduce a build github workflow #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Looks good to me! Regarding casing of files, I intended to make modules which have functions |
mcyph
approved these changes
Jan 13, 2022
junsikshim
approved these changes
Jan 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The build often has errors and they are only detected after a developer pull the
developmentbranch on their local machine.See #61 for instance.
Currently, we have errors due to some imports that are not respecting the case of the filenames. I guess this works on Windows but it cannot work on Linux.
To early catch build failures, I propose to add a GitHub workflow that runs a build command. This pull request also provide fixes for the imports.
Note that this is an initial version of the build automation. Feel free to comment if you see areas for improvements. But I would like we start we something quickly. We will be able to improve soon or later.