packages/core/src/view/style/config.ts (1)

131-132: Use type-safe initialization for the original config backup.

Instead of using type assertion, consider initializing the object with the same shape as ManhattanConnectorConfig.

Apply this diff:

-const originalManhattanConnectorConfig = {} as typeof ManhattanConnectorConfig;
-shallowCopy(ManhattanConnectorConfig, originalManhattanConnectorConfig);
+const originalManhattanConnectorConfig: ManhattanConnectorConfigType = {
+  maxAllowedDirectionChange: ManhattanConnectorConfig.maxAllowedDirectionChange,
+  maxLoops: ManhattanConnectorConfig.maxLoops,
+  endDirections: [...ManhattanConnectorConfig.endDirections],
+  startDirections: [...ManhattanConnectorConfig.startDirections],
+  step: ManhattanConnectorConfig.step,
+};

packages/website/docs/usage/global-configuration.md (2)

24-25: Fix indentation in the unordered list.

The indentation of the list items is inconsistent with the rest of the document. The markdownlint tool indicates that the indentation should be 2 spaces.

Apply this diff to fix the indentation:

-    - `ManhattanConnectorConfig` (since 0.16.0): for `ManhattanConnector`.
-    - `OrthConnectorConfig` (since 0.16.0): for `OrthConnector`.
+  - `ManhattanConnectorConfig` (since 0.16.0): for `ManhattanConnector`.
+  - `OrthConnectorConfig` (since 0.16.0): for `OrthConnector`.

🧰 Tools

🪛 markdownlint-cli2 (0.17.2)

24-24: Unordered list indentation
Expected: 2; Actual: 4

(MD007, ul-indent)

---

25-25: Unordered list indentation
Expected: 2; Actual: 4

(MD007, ul-indent)

---

35-36: Fix indentation in the unordered list.

The indentation of the list items is inconsistent with the rest of the document. The markdownlint tool indicates that the indentation should be 2 spaces.

Apply this diff to fix the indentation:

-    - `resetManhattanConnectorConfig` (since 0.16.0)
-    - `resetOrthConnectorConfig` (since 0.16.0)
+  - `resetManhattanConnectorConfig` (since 0.16.0)
+  - `resetOrthConnectorConfig` (since 0.16.0)

🧰 Tools

🪛 markdownlint-cli2 (0.17.2)

35-35: Unordered list indentation
Expected: 2; Actual: 4

(MD007, ul-indent)

---

36-36: Unordered list indentation
Expected: 2; Actual: 4

(MD007, ul-indent)

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

Learnt from: tbouffard
PR: maxGraph/maxGraph#582
File: packages/core/src/util/config.ts:0-0
Timestamp: 2024-11-23T16:12:51.380Z
Learning: The `shallowCopy` function in `cloneUtils.ts` is intentionally designed to perform a shallow copy on objects that contain only primitive properties, and deep copying is not necessary.

packages/core/src/view/style/EdgeStyle.ts (1)

1158-1163: ⚠️ Potential issue

Fix type errors in direction handling.

The DirectionValue[] type is not assignable to DIRECTION[]. This needs to be fixed in multiple locations.

Apply this diff to fix the type errors:

-        ? ManhattanConnectorConfig.startDirections.every(
+        ? (ManhattanConnectorConfig.startDirections as DIRECTION[]).every(
             (d) => d != DIRECTION.NORTH && d != DIRECTION.SOUTH
           )
-        : ManhattanConnectorConfig.endDirections.every(
+        : (ManhattanConnectorConfig.endDirections as DIRECTION[]).every(
             (d) => d != DIRECTION.NORTH && d != DIRECTION.SOUTH
           );

-        ? ManhattanConnectorConfig.startDirections.every(
+        ? (ManhattanConnectorConfig.startDirections as DIRECTION[]).every(
             (d) => d != DIRECTION.WEST && d != DIRECTION.EAST
           )
-        : ManhattanConnectorConfig.endDirections.every(
+        : (ManhattanConnectorConfig.endDirections as DIRECTION[]).every(
             (d) => d != DIRECTION.WEST && d != DIRECTION.EAST
           );

      const startPoints = getRectPoints(
        start,
-        ManhattanConnectorConfig.startDirections,
+        ManhattanConnectorConfig.startDirections as DIRECTION[],
        opt
      ).filter((p) => obstacleMap.isPointAccessible(p));

      const endPoints = getRectPoints(
        end,
-        ManhattanConnectorConfig.endDirections,
+        ManhattanConnectorConfig.endDirections as DIRECTION[],
        opt
      ).filter((p) => obstacleMap.isPointAccessible(p));

Also applies to: 1175-1180, 1198-1208

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

packages/html/stories/Manhattan.stories.ts (3)

26-26: Remove file extension from import path.

The import statement includes the .ts file extension, which is not a common practice in TypeScript and may cause issues with some bundlers.

-import EventObject from '@maxgraph/core/lib/view/event/EventObject.ts';
+import EventObject from '@maxgraph/core/lib/view/event/EventObject';

---

38-38: Consider using a more specific type for the Template function parameters.

Using Record<string, string> is too generic. Consider creating an interface that explicitly defines the expected properties.

-const Template = ({ label, ...args }: Record<string, string>) => {
+interface TemplateProps {
+  label?: string;
+  [key: string]: string | undefined;
+}
+const Template = ({ label, ...args }: TemplateProps) => {

---

51-56: Improve type safety in event handling.

The event handling code uses any type in several places. Consider creating proper interfaces for the change objects.

-  graph.model.addListener(InternalEvent.CHANGE, (_sender: any, evt: EventObject) => {
+interface GeometryChange {
+  geometry: unknown;
+  previous: unknown;
+}
+  graph.model.addListener(InternalEvent.CHANGE, (_sender: unknown, evt: EventObject) => {
     const changes = evt.getProperty('changes');
     const hasMoveEdits = changes?.some(
-      (c: any) => typeof c.geometry !== 'undefined' && typeof c.previous !== 'undefined'
+      (c: GeometryChange) => typeof c.geometry !== 'undefined' && typeof c.previous !== 'undefined'

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro