Skip to content

ci: include js-example-without-defaults during the build #669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tbouffard merged 1 commit into from
Feb 11, 2025
Merged

ci: include js-example-without-defaults during the build #669

tbouffard merged 1 commit into from
Feb 11, 2025

Conversation

@tbouffard
Copy link
Member

@tbouffard tbouffard commented Feb 10, 2025 •
edited by coderabbitai bot
Loading

This example is also archived in the example archive for further research if required.

Summary by CodeRabbit

  • Chores
    • Enhanced the automated build process by adding a new package build step.
    • Improved deployment procedures to capture an additional set of build artifacts.

@tbouffard
ci: include js-example-without-defaults during the build
a021358 
This example is also archived in the example archive for further research if required.
@tbouffard tbouffard added the chore Build, CI/CD or repository tasks (issues/PR maintenance, environments, ...) label Feb 10, 2025
@coderabbitai
Copy link

coderabbitai bot commented Feb 10, 2025 •
edited
Loading

Walkthrough

The changes update the GitHub Actions build workflow by adding a new step to build the js-example package without defaults. This step runs the command npm run build -w packages/js-example-without-defaults and the artifact upload step is modified to include the build output from packages/js-example-without-defaults/dist/.

Changes

Files Change Summary
.github/workflows/build.yml Added a new build step "Build js-example (without defaults)" executing npm run build -w packages/js-example-without-defaults, and updated the artifact upload to include packages/js-example-without-defaults/dist/.

Sequence Diagram(s)

sequenceDiagram
    participant Runner as GitHub Actions Runner
    participant Builder as Build Step
    participant Artifact as Artifact Uploader

    Runner->>Builder: Run "npm run build -w packages/js-example-without-defaults"
    Builder-->>Runner: Return build output
    Runner->>Artifact: Upload output from packages/js-example-without-defaults/dist/
Loading
📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 22d8a34 and a021358.

📒 Files selected for processing (1)
  • .github/workflows/build.yml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: build (windows-2022)
🔇 Additional comments (2)
.github/workflows/build.yml (2)

66-67: New Build Step for js-example (without defaults) Added
The newly added step to build the js-example-without-defaults package appears correct. Please ensure that the package exists with the proper configuration (e.g., in its package.json) so that this build command functions as expected.

75-75: Artifact Upload Path Updated for js-example (without defaults)
Including packages/js-example-without-defaults/dist/ in the artifact upload path is a good move to ensure that the build output is archived. Verify that the output directory matches the build configuration and that no extraneous files are picked up during artifact collection.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 10, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@tbouffard tbouffard merged commit cd0ef25 into main Feb 11, 2025
5 checks passed
@tbouffard tbouffard deleted the ci/build_js-example-without-defaults branch February 11, 2025 06:38
@coderabbitai coderabbitai bot mentioned this pull request Apr 7, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

chore Build, CI/CD or repository tasks (issues/PR maintenance, environments, ...)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@tbouffard