Skip to content

Conversation

@tbouffard
Copy link
Member

@tbouffard tbouffard commented Jan 3, 2025

Keep vite v5 in the storybook package as vite v6 is not marked as supported by storybook v7.

Summary by CodeRabbit

  • Dependency Updates
    • Updated @swc/core from ~1.7.26 to ~1.10.4 in @maxgraph/core
    • Updated @swc/jest from ~0.2.36 to ~0.2.37 in @maxgraph/core
    • Updated vite from ~5.4.11 to ~6.0.7 in @maxgraph/ts-example-vite projects

Keep vite v5 in the storybook package as vite v6 is not marked as supported by storybook v7.
@tbouffard tbouffard added dependencies skip-changelog Do not include in Changelog and Release Notes javascript Pull requests that update Javascript code labels Jan 3, 2025
@coderabbitai
Copy link

coderabbitai bot commented Jan 3, 2025

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

This pull request focuses on updating dependency versions across multiple package.json files in the project. The changes involve upgrading development dependencies in three different packages: @maxgraph/core, @maxgraph/ts-example-vite-without-defaults, and @maxgraph/ts-example-vite-custom-shapes. Specifically, the updates include version bumps for @swc/core, @swc/jest, and vite packages to their newer versions.

Changes

File Change Summary
packages/core/package.json Updated @swc/core from ~1.7.26 to ~1.10.4 and @swc/jest from ~0.2.36 to ~0.2.37 in devDependencies
packages/ts-example-without-defaults/package.json Updated vite from ~5.4.11 to ~6.0.7 in devDependencies
packages/ts-example/package.json Updated vite from ~5.4.11 to ~6.0.7 in devDependencies

Possibly related PRs


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d2c363c and e4a65e5.

📒 Files selected for processing (3)
  • packages/core/package.json (1 hunks)
  • packages/ts-example-without-defaults/package.json (1 hunks)
  • packages/ts-example/package.json (1 hunks)
🧰 Additional context used
🪛 GitHub Actions: Generate website
packages/ts-example/package.json

[error] Package.json and package-lock.json are out of sync. Multiple package version mismatches including @swc/core (1.7.26 vs 1.10.4), @swc/jest (0.2.36 vs 0.2.37), and missing packages like vite@6.0.7 and yaml@2.7.0

packages/ts-example-without-defaults/package.json

[error] Package.json and package-lock.json are out of sync. Multiple package version mismatches including @swc/core (1.7.26 vs 1.10.4), @swc/jest (0.2.36 vs 0.2.37), and missing packages like vite@6.0.7 and yaml@2.7.0

packages/core/package.json

[error] Package.json and package-lock.json are out of sync. Multiple package version mismatches including @swc/core (1.7.26 vs 1.10.4), @swc/jest (0.2.36 vs 0.2.37), and missing packages like vite@6.0.7 and yaml@2.7.0

🪛 GitHub Actions: Build
packages/ts-example/package.json

[error] Package.json and package-lock.json are out of sync. Multiple package version mismatches including @swc/core (1.7.26 vs 1.10.4), @swc/jest (0.2.36 vs 0.2.37), and missing packages like vite@6.0.7 and yaml@2.7.0

packages/ts-example-without-defaults/package.json

[error] Package.json and package-lock.json are out of sync. Multiple package version mismatches including @swc/core (1.7.26 vs 1.10.4), @swc/jest (0.2.36 vs 0.2.37), and missing packages like vite@6.0.7 and yaml@2.7.0

packages/core/package.json

[error] Package.json and package-lock.json are out of sync. Multiple package version mismatches including @swc/core (1.7.26 vs 1.10.4), @swc/jest (0.2.36 vs 0.2.37), and missing packages like vite@6.0.7 and yaml@2.7.0

🔇 Additional comments (1)
packages/core/package.json (1)

52-53: Verify SWC compatibility with current Jest version

The updates to @swc/core and @swc/jest look reasonable, but please ensure compatibility with the current Jest version (29.7.0).

Run the following to verify compatibility and fix sync issues:

After verifying, run npm install to sync package-lock.json with package.json.

✅ Verification successful

Let me gather more information about Jest compatibility.


Let me check the Jest configuration in the workspace packages.


Let me try one final check to locate Jest configuration.


SWC dependencies update looks compatible and safe

The verification shows:

  • @swc/jest has a flexible peer dependency on @swc/core (*)
  • @swc/core only requires @swc/helpers as a peer dependency
  • Jest tests are configured in the package and run via jest --runInBand
  • No explicit SWC transformer configuration was found, suggesting default configuration

The minor version updates to both SWC packages are compatible with each other and should work with the current Jest setup.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check compatibility between @swc packages and Jest

# Check if these versions are commonly used together
npm info @swc/jest@0.2.37 peerDependencies
npm info @swc/core@1.10.4 peerDependencies

# Verify no known issues exist
npm view @swc/jest@0.2.37 bugs.url
npm view @swc/core@1.10.4 bugs.url

Length of output: 293


Script:

#!/bin/bash
# Check Jest version and its dependencies
cat package.json | jq '.dependencies.jest, .devDependencies.jest'

# Search for Jest configuration files and SWC transformer setup
fd -e js -e json -e ts --full-path '.*jest.*config.*' -X cat

# Look for any existing SWC configuration
fd -e json -e js '.swcrc' -X cat

Length of output: 173


Script:

#!/bin/bash
# Check Jest configuration in workspace packages
fd -g 'packages/*/package.json' -X cat {} \; | jq -c 'select(.dependencies.jest != null or .devDependencies.jest != null) | {name: .name, jest: (.dependencies.jest // .devDependencies.jest)}'

# Look for Jest config files in packages
fd -g 'packages/*/jest.config.*' -X echo "=== {} ===" \; -X cat {}

Length of output: 268


Script:

#!/bin/bash
# Check core package.json for Jest and test configurations
cat packages/core/package.json | jq '.scripts | select(.test != null or .jest != null)'

# Look for any test scripts or configurations
rg -g '!node_modules' -g '!dist' -l 'transform.*swc' --type js --type json --type ts

Length of output: 426

🧰 Tools
🪛 GitHub Actions: Generate website

[error] Package.json and package-lock.json are out of sync. Multiple package version mismatches including @swc/core (1.7.26 vs 1.10.4), @swc/jest (0.2.36 vs 0.2.37), and missing packages like vite@6.0.7 and yaml@2.7.0

🪛 GitHub Actions: Build

[error] Package.json and package-lock.json are out of sync. Multiple package version mismatches including @swc/core (1.7.26 vs 1.10.4), @swc/jest (0.2.36 vs 0.2.37), and missing packages like vite@6.0.7 and yaml@2.7.0

@tbouffard tbouffard merged commit bd12b03 into main Jan 5, 2025
6 checks passed
@tbouffard tbouffard deleted the chore/bump_vite_and_test_deps branch January 5, 2025 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies javascript Pull requests that update Javascript code skip-changelog Do not include in Changelog and Release Notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant