-
Notifications
You must be signed in to change notification settings - Fork 199
chore(deps-dev): bump vite and test dependencies #617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Keep vite v5 in the storybook package as vite v6 is not marked as supported by storybook v7.
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (1)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including You can disable this status message by setting the WalkthroughThis pull request focuses on updating dependency versions across multiple package.json files in the project. The changes involve upgrading development dependencies in three different packages: Changes
Possibly related PRs
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
packages/core/package.json(1 hunks)packages/ts-example-without-defaults/package.json(1 hunks)packages/ts-example/package.json(1 hunks)
🧰 Additional context used
🪛 GitHub Actions: Generate website
packages/ts-example/package.json
[error] Package.json and package-lock.json are out of sync. Multiple package version mismatches including @swc/core (1.7.26 vs 1.10.4), @swc/jest (0.2.36 vs 0.2.37), and missing packages like vite@6.0.7 and yaml@2.7.0
packages/ts-example-without-defaults/package.json
[error] Package.json and package-lock.json are out of sync. Multiple package version mismatches including @swc/core (1.7.26 vs 1.10.4), @swc/jest (0.2.36 vs 0.2.37), and missing packages like vite@6.0.7 and yaml@2.7.0
packages/core/package.json
[error] Package.json and package-lock.json are out of sync. Multiple package version mismatches including @swc/core (1.7.26 vs 1.10.4), @swc/jest (0.2.36 vs 0.2.37), and missing packages like vite@6.0.7 and yaml@2.7.0
🪛 GitHub Actions: Build
packages/ts-example/package.json
[error] Package.json and package-lock.json are out of sync. Multiple package version mismatches including @swc/core (1.7.26 vs 1.10.4), @swc/jest (0.2.36 vs 0.2.37), and missing packages like vite@6.0.7 and yaml@2.7.0
packages/ts-example-without-defaults/package.json
[error] Package.json and package-lock.json are out of sync. Multiple package version mismatches including @swc/core (1.7.26 vs 1.10.4), @swc/jest (0.2.36 vs 0.2.37), and missing packages like vite@6.0.7 and yaml@2.7.0
packages/core/package.json
[error] Package.json and package-lock.json are out of sync. Multiple package version mismatches including @swc/core (1.7.26 vs 1.10.4), @swc/jest (0.2.36 vs 0.2.37), and missing packages like vite@6.0.7 and yaml@2.7.0
🔇 Additional comments (1)
packages/core/package.json (1)
52-53: Verify SWC compatibility with current Jest versionThe updates to @swc/core and @swc/jest look reasonable, but please ensure compatibility with the current Jest version (29.7.0).
Run the following to verify compatibility and fix sync issues:
After verifying, run
npm installto sync package-lock.json with package.json.✅ Verification successful
Let me gather more information about Jest compatibility.
Let me check the Jest configuration in the workspace packages.
Let me try one final check to locate Jest configuration.
SWC dependencies update looks compatible and safe
The verification shows:
- @swc/jest has a flexible peer dependency on @swc/core (
*)- @swc/core only requires @swc/helpers as a peer dependency
- Jest tests are configured in the package and run via
jest --runInBand- No explicit SWC transformer configuration was found, suggesting default configuration
The minor version updates to both SWC packages are compatible with each other and should work with the current Jest setup.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Check compatibility between @swc packages and Jest # Check if these versions are commonly used together npm info @swc/jest@0.2.37 peerDependencies npm info @swc/core@1.10.4 peerDependencies # Verify no known issues exist npm view @swc/jest@0.2.37 bugs.url npm view @swc/core@1.10.4 bugs.urlLength of output: 293
Script:
#!/bin/bash # Check Jest version and its dependencies cat package.json | jq '.dependencies.jest, .devDependencies.jest' # Search for Jest configuration files and SWC transformer setup fd -e js -e json -e ts --full-path '.*jest.*config.*' -X cat # Look for any existing SWC configuration fd -e json -e js '.swcrc' -X catLength of output: 173
Script:
#!/bin/bash # Check Jest configuration in workspace packages fd -g 'packages/*/package.json' -X cat {} \; | jq -c 'select(.dependencies.jest != null or .devDependencies.jest != null) | {name: .name, jest: (.dependencies.jest // .devDependencies.jest)}' # Look for Jest config files in packages fd -g 'packages/*/jest.config.*' -X echo "=== {} ===" \; -X cat {}Length of output: 268
Script:
#!/bin/bash # Check core package.json for Jest and test configurations cat packages/core/package.json | jq '.scripts | select(.test != null or .jest != null)' # Look for any test scripts or configurations rg -g '!node_modules' -g '!dist' -l 'transform.*swc' --type js --type json --type tsLength of output: 426
🧰 Tools
🪛 GitHub Actions: Generate website
[error] Package.json and package-lock.json are out of sync. Multiple package version mismatches including @swc/core (1.7.26 vs 1.10.4), @swc/jest (0.2.36 vs 0.2.37), and missing packages like vite@6.0.7 and yaml@2.7.0
🪛 GitHub Actions: Build
[error] Package.json and package-lock.json are out of sync. Multiple package version mismatches including @swc/core (1.7.26 vs 1.10.4), @swc/jest (0.2.36 vs 0.2.37), and missing packages like vite@6.0.7 and yaml@2.7.0
Keep vite v5 in the storybook package as vite v6 is not marked as supported by storybook v7.
Summary by CodeRabbit
@swc/corefrom~1.7.26to~1.10.4in@maxgraph/core@swc/jestfrom~0.2.36to~0.2.37in@maxgraph/corevitefrom~5.4.11to~6.0.7in@maxgraph/ts-example-viteprojects