fix: prevent error when not passing "mapping" to Graph.cloneCell #413
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, this generated an error in `ConnectionHandler` because the default mapping value was invalid (null is not allowed) and the error opened a MaxLog without error message. ConnectionHandler has been updated to better track such an error. The `ContexIcons` story exhibited the problem. It is now fully working. It has also been migrated to TypeScript to ease future maintenance. Also update the `ConnectionHandler.start` method signature as part of the migration of the story to TypeScript. The `edgeState` parameter can now be undefined, a default value was already managed in code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, this generated an error in
ConnectionHandlerbecause the default mapping value was invalid (null is not allowed) and the error opened a MaxLog without error message. ConnectionHandler has been updated to better track such an error.The
ContexIconsstory exhibited the problem. It is now fully working. It has also been migrated to TypeScript to ease future maintenance.Also update the
ConnectionHandler.startmethod signature as part of the migration of the story to TypeScript.The
edgeStateparameter can now be undefined, a default value was already managed in code.Notes
Closes #73
The fix was inspired by inspired from 0bdae3b