Skip to content

Conversation

@jgadsden
Copy link

Summary
This pull request provides a template for further templates.
It prompts the contributor to provide information for the reviewers

Description for the changelog
Add Pull-Request template

Other info
We need to reference the contributing guidelines when they are in place

@jgadsden jgadsden requested review from coclav, junsikshim and mcyph May 11, 2021 06:12
@jgadsden jgadsden self-assigned this May 11, 2021
@jgadsden
Copy link
Author

@tbouffard do you want to add yourself to the reviewers? github will not let me just yet, I think you have to agree to the invite first before I can do this. I have sent an invite to be a maintainer of this project

@tbouffard tbouffard self-requested a review May 11, 2021 08:55
Copy link
Member

@tbouffard tbouffard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, this is a good start to handle new contributions.

@jgadsden
Copy link
Author

cool, thanks - two reviewers are good enough to merge 👍🏾

@jgadsden jgadsden merged commit 4e3c92b into development May 11, 2021
@jgadsden jgadsden deleted the jgadsden-pr-template-dev branch May 11, 2021 09:07
@tbouffard tbouffard added the documentation Improvements or additions to documentation label Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants