fix: correctly manage default style.foldable value
#385
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, when a cell's `style.foldable` property was not set, everything happened as if it was set to `false`, whereas it should have considered as `true`. Thus, by default, the expand image was not displayed, and it was not possible to expand the cell. The problem was due to an error during mxGraph migration. The Folding story presented the problem. It has been migrated to TypeScript and updated to work better. The expand/collapse images and actions are now available. Some mxGraph features still don't work (highlighting the parent when dragging a cell, parent association).
Member
Author
|
Put in draft, the Swimlanes story should also display the expand/collapse image. To be tested |
Use a shared function to set the graph options.
This was referenced Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when a cell's
style.foldableproperty was not set, everything happened as if it was set tofalse, whereas it should have considered astrue. Thus, by default, the expand image was not displayed, and it was not possible to expand the cell.The problem was due to an error during mxGraph migration.
Some stories exhibited the problem. The expand/collapse images and actions are now available.
Folding:SwimlanesandCollapse. Some mxGraph features still don't work like applying custom style when the cell are collapsedNotes
Closes #175
There is an issue in the code which detects if the cell is foldable. If not set in the style, the cell is considered as non foldable where it should be by default.
The mxGraph code wasn't migrated correctly
Folding story not full working - comparison with mxGraph
mxGraph 4.2.2 (https://jgraph.github.io/mxgraph/javascript/examples/folding.html)
maxGraph Folding story with this PR
Fixes in Collapse and Swimlanes
Collapse story
Swimlanes story