fix: make usage of Codecs work in stories #350
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, some stories still encode/decode by calling directly the Codec code. Default Codecs were not registered so errors occurred. Most of the stories updated as part of the fix have been migrated to TypesScript to also fix other minor issues. Clipboard (still in JavaScript) The Clipboard actions still don't work and have not been touched as this is out of the scope of the changes proposed here. The code that uses the Codecs to generate the xml string used for copy/paste (the string representation of the cells to copy) is now working (the Codec are registered). FileIO - load of txt and xml file works - the user can choose the source of the model with a Storybook control - display images - display the "arrange" button JSonData - display the content - display the popup UserObject - load images (for popup) - fix style and form div - improve the layout - fix error when validating new value in the form (wrong import) DISCLAIMER about the maxGraph "popup" The CSS class are still not correctly set in the maxGraph code, so popup still don't display correctly. The popup are not cleaned when changing from a story to another, as they are currently not created in the DOM at the right place. They are created directly in whole document, so not at the place where the story is located in the DOM (not in the right div).
This was referenced Mar 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, some stories still did encode and/or decode by calling directly the Codec code. Default Codecs were not registered so errors occurred. This is now done by using
ModelXmlSerializer.Most of the stories updated as part of the fix have been migrated to TypesScript to also fix other minor issues.
Clipboard (still in JavaScript)
The Clipboard actions still don't work and have not been touched as this is out of the scope of the changes proposed here.
The code that uses the Codecs to generate the XML string used for copy/paste (the string representation of the cells stored in the clipboard) is now working (as the Codecs are registered).
FileIO
JSonData
UserObject
DISCLAIMER about the maxGraph "popup"
The CSS class are still not correctly set in the
maxGraphcode, so popups still don't display correctly.The popups are not cleaned when changing from a story to another, as they are currently not created in the DOM at the right place. They are created directly in whole document, so not at the place where the story is located in the DOM (not in the right div).
Closes #337
Covers #73