removed all mxConstants.STYLE_* references, now referring to keys directly #31
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've removed all the different
STYLE_variables frommxConstantsto reduce the complexity of various files.Next step I hope to create style templates which directly assign defaults to each variable so that they're stored in fewer places e.g.:
I'd also like to remove
mxUtils.getValueand similar methods, and make it so types are clarified. In particular, boolean values can be"1"/"0",1/0,true/falsein various places and would like to make them all simply usetrueandfalseunless there's a good reason not to because of the way things serialized. If these changes were made, it should be possible to change the following from:to be just: