forked from jgraph/mxgraph
-
Notifications
You must be signed in to change notification settings - Fork 199
feat: allow to load an XML-stored model produced by mxGraph
#300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
tbouffard
merged 74 commits into
development
from
feat/import_xml_mxGraph_model_with_object_codecs
Jan 16, 2024
Merged
feat: allow to load an XML-stored model produced by mxGraph
#300
tbouffard
merged 74 commits into
development
from
feat/import_xml_mxGraph_model_with_object_codecs
Jan 16, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # packages/core/src/serialization/register.ts
…ded (hard coded) We now have the same issue as with the maxgraph model. Geometry is not correctly decoded
… having fix mxCell resolution
tbouffard
commented
Jan 15, 2024
packages/core/__tests__/serialization/codecs/mxgraph/utils.test.ts
Outdated
Show resolved
Hide resolved
packages/core/__tests__/serialization/codecs/mxgraph/utils.test.ts
Outdated
Show resolved
Hide resolved
packages/core/src/serialization/codecs/mxGraph/mxGeometryCodec.ts
Outdated
Show resolved
Hide resolved
tbouffard
commented
Jan 16, 2024
[skip ci]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation relies on both the declaration of aliases and the introduction of dedicated codecs.
Codec.getCodecByNamenow takes aliases into account, so that importing is fully functional.The code of some
CodecRegistryandCodecmethods has been simplified (check for nullity of method parameters).The cell style is converted thanks to a specific utility function that can serve as an example for those wishing to migrate their applications from mxGraph to maxGraph.
test
Codecexample has been restored from the stashed directory. It is now available as a story written in TypeScript.ModelCheckerutility class was previously used only to validate the imported model after import from the maxGraph model. It is now shared and also used in mxGraph import tests. It has also been enhanced to check the total number of cells in the model.Closes #293
Screenshots of the Codec story
For comparison with mxGraph: https://jgraph.github.io/mxgraph/javascript/examples/codec.html