Skip to content

Conversation

@holyhope
Copy link

Signed-off-by: Pierre Péronnet pierre.peronnet@ovhcloud.com

Signed-off-by: Pierre Péronnet <pierre.peronnet@ovhcloud.com>
@jgadsden jgadsden self-requested a review May 10, 2021 21:16
Copy link

@jgadsden jgadsden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @holyhope - could you provide the reason for this change please? Also is there an issue that it addresses?

No problem with the change itself, just needed to know the reasoning

@holyhope
Copy link
Author

Hello @jgadsden ,

Thank you for the reply.

Of course you are right, moreover on github reviews, only few context lines are shown.

This changes is a fix probably due to a bad copy/past:
The comment does not match the variable.
So I updated the variable name as well as the default value to match the real value fee line later.

@tbouffard
Copy link
Member

We currently cannot accept Pull Request targetting the main branch due to a license issue and we need to clarify it first IMHO. See #35.
That being said, the mxForceIncludes documentation is out-of-sync with the code (unfortunately, this is something that is present in a lot of mxGraph API documentation), so the content of this Pull Request is valid.

Regarding the mxForceIncludes global, I hope we will remove it in the development branch: this was a poor way used by the project to test the changes while developing. In addition, it is one of the property that wasn't set correctly while initializing mxGraph when using the npm package (jgraph#479) and also caused issue when using in TypeScript project (https://github.com/typed-mxgraph/typed-mxgraph-example-bundled-with-rollup/blob/f576c1bfeb7a45488cfa8c613f94517a4003477d/src/mxgraph-loader.ts#L10)

@jgadsden
Copy link

jgadsden commented May 11, 2021

I agree @tbouffard that we need to use development branch for the time being. This caught me out as well @holyhope and I have changed my two pull requests to be for development rather than main.

@holyhope could you recreate your proposed changes against development branch, taking into account @tbouffard comments? And then close (without merging) this pull request

Thanks, Jon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants