fix: ensure decode works without encode first #297
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Declare generic `ObjectCodec` for `Cell` properties that are defined as XML node. Codecs are currently only registered automatically during encode/export, so for now, they have to be registered to be available during decode/import. Also improve some methods signatures in base Codec objects (use specific types instead of `any`).
tbouffard
commented
Jan 2, 2024
packages/core/__tests__/serialization/serialization.xml.test.ts
Outdated
Show resolved
Hide resolved
packages/core/__tests__/serialization/serialization.xml.test.ts
Outdated
Show resolved
Hide resolved
packages/core/__tests__/serialization/serialization.xml.test.ts
Outdated
Show resolved
Hide resolved
packages/core/__tests__/serialization/serialization.xml.test.ts
Outdated
Show resolved
Hide resolved
packages/core/__tests__/serialization/serialization.xml.test.ts
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Declare generic
ObjectCodecforCellproperties that are defined as XML node. Codecs are currently only registered automatically during encode/export, so for now, they have to be registered to be available during decode/import.Also improve some methods signatures in base Codec objects (use specific types instead of
any).Closes #178