Removed mxUtils' indexOf(), bind(), and forEach(). #27
Conversation
|
In addition, I refactored mxConstants so each variable/function is exported independently. |
There was a problem hiding this comment.
The (x) => {} syntax was originally removed by ESLint in favor of x => {} when I auto-formatted - it'd be great if there was a standard so it doesn't make many changes at once, but I don't have any preference for either way so will check my IDE to make sure it doesn't keep switching between yours and my style when committing.
I think the changes with the constants to remove mxConstants. is a good move, removing some more of the constants directly could be an idea too going forwards. I started doing this for the styles but hadn't finished e.g. in mxForm and a few other files. Removing DIALECT_SVG entirely could be a good idea too, as I think it's likely we won't use any other rendering modes going forwards.
I think we're making steady progress! Sorry for not reviewing for the last few days because of work, hoping to be able to get a few more example files from the stashed directory converted this weekend.
|
@mcyph I just use 'format on save' feature in vscode with 'default formatter' set to prettier(esbenp.prettier-vscode). I feel like we can discard all of |
Removed mxUtils' indexOf(), bind(), and forEach() as they are widely supported now.
I changed the all the examples in the storybook accordingly, but didn't touch the ones in
docs.Also removed unused imports in the files.
Thanks!