Moved list operations from mxGraphModel to mxCells, some calls in mxGraph to mxCell, bugfixes #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…om mxGraphModel.ts
# Conflicts: # src/pages/connections/HelloPort.js # src/pages/dnd_copypaste/Clipboard.js # src/pages/effects/Morph.js # src/pages/events/Boundary.js # src/pages/layout/AutoLayout.js # src/pages/layout/SwimLanes.js # src/pages/layout/Tree.js # src/pages/printing/PageBreaks.js # src/pages/shapes_stencils/Shape.js # src/pages/shapes_stencils/Stencils.js # src/pages/styles/HoverStyle.js # src/pages/styles/Stylesheet.js # src/pages/windows/Windows.js # src/pages/xml_json/FileIO.js # src/pages/xml_json/JsonData.js # src/pages/xml_json/UserObject.js # src/pages/zoom_offpage/OffPage.js # src/public/editors/config/editor-commons.xml # src/public/map-background/map-background.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I've been doing as part of this change is moving non-transaction/"set" operations into
mxCells(a list structure for working onmxCellin batch) andmxCell. Also fixed a few bugs with the storybook modules.While doing things directly against mxCell is more direct and easier to read than through mxGraphModel or mxGraph, these changes may break existing code if the relevant methods in mxGraphModel or mxGraph are overridden. I think in these cases it may pay to disallow setting these properties with an error message and to write docs on how to migrate, as I can't at the moment think of a clean way of refactoring these modules without breaking compatibility to some degree.