Converted all the examples for '@mxgraph/html'. #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add icons to mxgraph. - Convert some examples to storybook.
- Convert more examples to storybook.
- Convert more examples.
- Convert the rest examples. - src/ is removed.
mcyph
approved these changes
Apr 25, 2021
Collaborator
mcyph
left a comment
There was a problem hiding this comment.
Great work! I can't see huge issues being likely to appear with these changes and think it's best to merge together now as have made a few changes to the core myself in the interim. If need be we can roll back but I'm 80% sure that won't be necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains all the examples for '@mxgraph/html'.
However, not everything is working correctly as there's still some refactoring going on.
I'm trying to set the working environment first so we can easily test against the examples as we change the core code.
'/src' directory has been removed, but not all the static files have been transferred.
I'll move them when they seem necessary.
Thanks!