Made calls go directly to mxCell rather than through mxGraphModel in many cases #24
Conversation
|
What are those |
Yeah, they are the examples I didn't convert/started converting to react but hadn't yet finished. I put them there outside the source code tree because React/next.js wouldn't work unless all the javascript files were parseable. Those "stashed" examples were still there prior to this PR, and mainly only things related to |
|
I wonder how the big "Editor" code differs in scope and whether it was derived from/turned into https://draw.io ? I'm wondering whether it may be worth investigating whether https://github.com/jgraph/drawio itself could be converted to ES9 and added to the library/put into an external package if it's not orders of magnitude larger. |
Oh, I just realized I had Btw, I'm still converting your examples(the ones in |
In this PR I've made it so most calls in the examples and core go directly to
mxCellrather than going throughmxGraphModelto improve readability+simplicity for newer users. The previous functions inmxGraphModelare still there but now forward to themxCellfunction with a// SLATED FOR DELETIONcomment to indicate it may be removed at a later date.So for example:
will become
I also have started to remove some of the
nulls as possible types to functions inmxCellto try to eliminate bugs which occur due tonulls being accidentally passed to functions and no exception raised, but please note this also will introduce bugs in some cases, especially wherenullis passed from non-typescript/plain-js files which don't have as strict checking.