-
Notifications
You must be signed in to change notification settings - Fork 199
refactored to be ES9; converted some files to TypeScript; added documentation from typed-mxgraph #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
jgadsden
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pull request contains a large number of commits, which makes it very difficult to review this.
Yeah sorry about this :/ I have effectively changed the style of almost the entire library codebase multiple times over, with conversions to ES9, TypeScript, and most documentation. It's obviously not ideal, though to be honest my assessment was because the codebase was so large (90k+ lines) not doing things in batch could have taken months, if not years, if a release was ever possible. That said, aside from style changes and removing of VML/IE support to my knowledge the behavior of the code hasn't changed significantly.
Let me know whether you think any changes should be made or what action you think is most appropriate. I won't have time to do it for the time being, but my personal thoughts are merging to dev now, but planning to create some python scripts to easily compare the old functions with the new ones side-by-side on top of sorting the examples+documentation out could be one of the better solutions. |
jgadsden
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @mcyph - I had a mad moment, and thought this was going to main branch. But of course it is going into the development branch as we discussed, so many apologies for asking for more work on something that is perfectly OK.
Approved!
As per discussion at #8: