Skip to content

chore: force usage of a recent @types/node version #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tbouffard merged 1 commit into from
Nov 22, 2022
Merged

chore: force usage of a recent @types/node version #143

tbouffard merged 1 commit into from
Nov 22, 2022

Conversation

@tbouffard
Copy link
Member

@tbouffard tbouffard commented Nov 22, 2022 •
edited
Loading

Summary

Use a recent version of @types/node that works with TypeScript 4.9, older versions have types issues.

Other info

This wasn't detected by the GitHub Actions but the problem could happen locally depending on the content of the existing node_modules directory.

Fixed error

Error: node_modules/@types/node/globals.d.ts(72,13): error TS2403: Subsequent variable declarations must
have the same type.  Variable 'AbortSignal' must be of type '{ new (): AbortSignal;
prototype: AbortSignal; abort(reason?: any): AbortSignal; timeout(milliseconds: number): AbortSignal; }',
but here has type '{ new (): AbortSignal; prototype: AbortSignal; }'.

@tbouffard
chore: force usage of a recent @types/node version
cce2bb4 
Use a recent version of `@types/node` that works with TypeScript 4.9, older versions have types issues.
@tbouffard tbouffard added the chore Build, CI/CD or repository tasks (issues/PR maintenance, environments, ...) label Nov 22, 2022
@tbouffard tbouffard merged commit 6fe7f7f into development Nov 22, 2022
@tbouffard tbouffard deleted the chore/bump_types_node_version branch November 22, 2022 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

chore Build, CI/CD or repository tasks (issues/PR maintenance, environments, ...)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@tbouffard