fix: types of Hierarchical and Swimlane Layout #124
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These types are only used in the layout classes, so keep them located closed in the folder where they are used.
tbouffard
approved these changes
Oct 9, 2022
Member
tbouffard
left a comment
There was a problem hiding this comment.
LGTM thanks @mayorovad for you work
I moved the types to a file in the layout folder and apply prettier to the code.
I also updated the README to remove the skipLibCheck configuration which is not needed anymore.
I let this PR opened to let you see the changes I proposed. If this is ok for you, then I will merge it quickly. Otherwise, let's discuss and find an agreement 😸
Author
|
Thanks for changes @tbouffard ! I think it's much better now ✔️ |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is fix for part of #96. Added interfaces for
traversefunction ofGraphLayout,HierarchicalLayoutandSwimlaneLayout, which fixed typescript build error.Description for the changelog
Fixes issue #96 regarding HierarchicalLayout and SwimlaneLayout
Other info
Swimlanestory still not working 😿