Fix stories with overlays usage #121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbouffard
approved these changes
Oct 9, 2022
Member
tbouffard
left a comment
There was a problem hiding this comment.
Nice catch! Thanks for all the PR you provide 💯 .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Because
overlaysfield ofCellis now initialized with empty array instead ofundefined, code from examples is broken.maxGraph/packages/core/src/view/cell/Cell.ts
Lines 103 to 104 in 02ea6f1
maxGraph/packages/html/stories/Overlays.stories.js
Lines 63 to 65 in 02ea6f1
This branch will never execute.
Changed check for
nullto check for empty array.Description for the changelog
Fix stories with overlays usage