Skip to content

Fix wrong method signature in EdgeMixin #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tbouffard merged 2 commits into from
Oct 10, 2022
Merged

Fix wrong method signature in EdgeMixin #119

tbouffard merged 2 commits into from
Oct 10, 2022

Conversation

@mayorovad
Copy link

@mayorovad mayorovad commented Oct 5, 2022

Summary
There are clearly typo in type for resetEdgesOnMove, fixed it

maxGraph/packages/core/src/view/mixins/EdgeMixin.ts

Lines 31 to 33 in 02ea6f1

resetEdgesOnResize: boolean;
resetEdgesOnMove: false;
resetEdgesOnConnect: boolean;

@tbouffard tbouffard added the bug Something isn't working label Oct 5, 2022
@mayorovad mayorovad closed this Oct 9, 2022
@mayorovad mayorovad reopened this Oct 9, 2022
tbouffard
tbouffard approved these changes Oct 10, 2022
View reviewed changes
Copy link
Member

@tbouffard tbouffard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks

@tbouffard tbouffard changed the title Fixed typo in EdgeMixin Fix wrong method signature in EdgeMixin Oct 10, 2022
@tbouffard tbouffard merged commit 5b1369b into maxGraph:development Oct 10, 2022
@mayorovad mayorovad deleted the edge-mixin-typo branch October 13, 2022 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tbouffard tbouffard tbouffard approved these changes

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mayorovad @tbouffard