fix: Fix for cells not removed #115
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.


Summary
This is fix for #114. There is logical error in processing
ChildChangeinGraph. When cell is removed,ChildChangecreated to change parent of removed cell tonull. But in code, if parent is null, code to destroy child cell state is not called, so cell stays rendered on canvas.maxGraph/packages/core/src/view/Graph.ts
Lines 589 to 599 in 02ea6f1
Added check for "falsy" parent so correct branch of code will be executed and cells will be destroyed.
Description for the changelog
Fixed bug with cells not removing when calling
Graph.removeCells()closes #114