Skip to content

Fixed Visibility story #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tbouffard merged 1 commit into from
Oct 9, 2022
Merged

Fixed Visibility story #113

tbouffard merged 1 commit into from
Oct 9, 2022

Conversation

@mayorovad
Copy link

@mayorovad mayorovad commented Oct 3, 2022

Summary
Fixed Visibility story. When porting from examples, result variable in overriden function isVisible() left undefined, so function always return undefined, hence all cells are invisible.

maxGraph/packages/html/stories/Visibility.stories.js

Lines 60 to 71 in 02ea6f1

const isVisible = function () {
// TODO super cannot be used here
// let result = super.isVisible();
let result;
if (result && this.value != null) {
result =
(showOne && this.value == '1') ||
(showTwo && this.value == '2') ||
(showThree && this.value == '3');
}
return result;
};

Init result with true for story begin to work.

Description for the changelog
Fixed bug in Visibility story in Storybook

@mayorovad mayorovad mentioned this pull request Oct 3, 2022
Closed
@tbouffard tbouffard added the bug Something isn't working label Oct 7, 2022
@tbouffard tbouffard merged commit a617bb6 into maxGraph:development Oct 9, 2022
@mayorovad mayorovad deleted the visibility-story-fix branch October 13, 2022 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@junsikshim junsikshim junsikshim approved these changes

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mayorovad @junsikshim @tbouffard