Skip to content

Conversation

@mayorovad
Copy link

Summary
GraphDataModel.cells variable were set to any, so method getCell are returning any too. After analyzing code, it's seems that type {[key: string]: Cell} | null is best fit.

Description for the changelog
Changed type of cells variable to {[key: string]: Cell} | null

Copy link
Member

@tbouffard tbouffard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@tbouffard tbouffard merged commit 61ab219 into maxGraph:development Oct 7, 2022
@mayorovad mayorovad deleted the graph-model-typings branch October 7, 2022 17:44
@mayorovad mayorovad restored the graph-model-typings branch October 7, 2022 17:47
@tbouffard tbouffard added the bug Something isn't working label Oct 10, 2022
@mayorovad mayorovad deleted the graph-model-typings branch October 13, 2022 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants