Fixes null checks in SvgCanvas2D #107 #108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I confirmed this PR fixes the |
Member
|
I have tests the stories with the changes proposed in this PR. Everything run fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In order to resolve TS errors, I previously added null checks to some of the functions.
However, this has brought some unintentional side-effects mentioned in #107 .
So, I removed those null checks and used non-null assertion operator instead.
It's not optimal, but I think it's ok for now.
closes #107
Description for the changelog
Fixes null checks in SvgCanvas2D.
Other info
Other files may also contain such null checks. I assume the most of them won't cause problems, but there could be similar side-effects.