Replies: 5 comments 23 replies
-
|
Hello @nbelyh |
Beta Was this translation helpful? Give feedback.
-
|
Probably the right person to CC: @shakeZSL |
Beta Was this translation helpful? Give feedback.
-
|
@nbelyh I don't think we're hugely far off getting a release once getting the serialization and possibly the styling system worked out, but until then I think that's the best choice, as there are still breaking changes to be made. The examples and explanations need to be updated within the comments. In some ways the new docs are more complete/correct than the old ones in terms of the required types etc, and most examples have already been ported to storybook (aside from the editor). Will try to work on the remaining ones as soon as feasible. |
Beta Was this translation helpful? Give feedback.
-
|
Thank you for your suggestion, the fix worked great! I guess we will follow @nbelyh's advice. However i will still try to test some stuff. |
Beta Was this translation helpful? Give feedback.
-
|
I have just created #74 to fix the storybook startup error |
Beta Was this translation helpful? Give feedback.
-
|
this has been merged! |
Beta Was this translation helpful? Give feedback.
-
|
It's been on a a hiatus for a while, but @junsikshim made some pretty major progress a few months ago, and I've made reasonably large changes in the last few days in my branch at https://github.com/mcyph/mxGraph/tree/development. A big problem is that on the one hand many existing applications rely on the current version. On the other, it would be very tricky to make more than incremental changes to e.g. add support for new browser versions because of how complex and tightly integrated the library is. This is from the original authors in reference to the draw.io/diagrams.net project, but I think a lot of this also applies to mxGraph (maxGraph is an unofficial fork which started after development on mxGraph stopped):
Just like the touch element event issues you ran into, much of the logic of maxGraph extends across many files, and making one change can have unintended consequences. My hope was by introducing TypeScript and recent JavaScript syntax that it could reduce the cascade effect and allow more people to understand and build on the code. Unfortunately, in trying to sort out e.g. global assigning of variables to prototypes and the state of one graph affecting another it was pretty much inevitable that compatibility would be broken to some degree, potentially needing a rewrite of parts of previously written applications, if they would be feasible. For this reason, I think there is a case to keep both the existing version and the rewrite maintained, but personally for both real life reasons (juggling uni/work/other projects/PC instability..), and practical ones like that I don't have much experience with the previous version of the library mean that I could only provide minimal support for the older version, and so have mainly been focusing my efforts on the new code base. There are currently no tests, so whether things function correctly relies on manual testing - I think this may be inevitable because writing unit tests for something like this would be a gigantic task, if even possible for much of it. The currently available TypeScript definition files were a good first step, but they along with the types in the original documentation were incomplete and contained many inaccuracies which would be difficult to solve without coding the library itself in TypeScript. This is the first time I've had a chance in the last few months to develop, and am trying to focus on the following areas in the last few days:
The first couple of items are already some way towards being completed. I'd also like to finish off all the examples, including some ones which haven't yet been updated for the changed code, but think will work on the specifics after working thru the above issues. |
Beta Was this translation helpful? Give feedback.
-
|
@nbelyh yep, VML is already gone, removed many months ago - I accidently removed some mixed HTML stuff I shouldn't have before I understood what it did though and want to add it back as soon as possible..I do fully agree with you re the "set of files I am playing with when I have free time" bit but my experience is the time between "there's so much to annotate and get done" and "it's all annotated and not much more to do" is surprisingly short+it takes some time to get there. Once it gets to that stage I think that will be much more feasible. |
Beta Was this translation helpful? Give feedback.
-
|
still have some way to go before being able to merge with development, but have created a new branch at https://github.com/maxGraph/maxGraph/tree/bleeding-edge with the recent changes |
Beta Was this translation helpful? Give feedback.
-
|
@mcyph Having I definitely agree with removing the |
Beta Was this translation helpful? Give feedback.
-
|
@tbouffard @junsikshim @nbelyh I've finished off a majority of the red underlined errors and got most the examples in my bleeding-edge branch working again. There's a small amount of bugs which were either in the original version mxGraph and identified by TypeScript which still need to be fixed and a few files left, but all but a handful of the files have been annotated with types, which means a lot of the changes which were previously tricky should hopefully be much easier from now onwards. Hoping can stabilise this soon+finish off the annotations so that we can use TypeDoc or similar to generate the API documentation. Updating the API docs and finishing off the unconverted/broken examples will be a large amount of what still needs to be done, but we've already done a reasonable amount of the groundwork and will update with more details soon! |
Beta Was this translation helpful? Give feedback.
-
|
Finished off all annotations+TypeDoc generation now works (a preview is at https://mcyph.github.io/mxgraph/api/). This is about all I can do for now - I'll write some docs on what's changed and migration etc soon. The parameters and types themselves should mostly be complete, and I think they should be useful as-is, but example code and explanations need to be updated. |
Beta Was this translation helpful? Give feedback.
-
|
Hello. I just want to confirm the status of this project. It looks active, but I feel like I'm seeing conflicting information, so I just want to know if this is something that could be used for a project that will start small with potential for growth. Thanks. |
Beta Was this translation helpful? Give feedback.
-
|
Hi yes the project is alive. The Readme has been updated recently to provide more accurate information. |
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.
-
|
Please post in a dedicated topic and remove this comment |
Beta Was this translation helpful? Give feedback.
-
|
done |
Beta Was this translation helpful? Give feedback.
-
|
The first release of |
Beta Was this translation helpful? Give feedback.
-
|
🎉 🎉 🎉 |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
-
Dear all, I am a newcomer, interested in keeping mxgraph alive as a library and not in a form of "diagrams.net"
Could you kindly update me, what is the status of this fork - is somebody working on this?
It looks like there is not much happening. Is it a dead project?
Beta Was this translation helpful? Give feedback.
All reactions