Add feedback per letter of correct vs incorrect#90
Merged
max-niederman merged 2 commits intomax-niederman:mainfrom Oct 3, 2023
Merged
Add feedback per letter of correct vs incorrect#90max-niederman merged 2 commits intomax-niederman:mainfrom
max-niederman merged 2 commits intomax-niederman:mainfrom
Conversation
This was referenced Sep 27, 2023
max-niederman
approved these changes
Oct 3, 2023
Features added: - only incorrect character in red - if space is pressed too early, the previous word shows up as still partially untyped - if type after the end of word, the extra letters will show up as errors (like in monkeytype)
51d20c4 to
9b61303
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Features added:
This goes in the direction of ttyper V2 as mentioned in this issue (#83)
I am not super sure about the structure of the code, so I appreciate feedback if you think there was a better way to implement this.