refactor(cli): migrate from structopt to clap-derive#120
Merged
max-niederman merged 2 commits intomax-niederman:mainfrom Apr 27, 2024
Merged
refactor(cli): migrate from structopt to clap-derive#120max-niederman merged 2 commits intomax-niederman:mainfrom
max-niederman merged 2 commits intomax-niederman:mainfrom
Conversation
595c0ab to
026b1ce
Compare
max-niederman
requested changes
Apr 27, 2024
026b1ce to
65237d1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
structoptis quite old and unmaintained, and porting its code to pure clap-derive is straightforward for this codebase.Hope this proves useful, but here are some additional notes:
wordsto u32 and casting it later to usize, as clap doesn't support *size types here.