Skip to content

add: wordlists of portuguese with 200, 1000 lines and advanced…#119

Merged
max-niederman merged 3 commits intomax-niederman:mainfrom
mohvn:main
Apr 25, 2024
Merged

add: wordlists of portuguese with 200, 1000 lines and advanced…#119
max-niederman merged 3 commits intomax-niederman:mainfrom
mohvn:main

Conversation

@mohvn
Copy link
Copy Markdown
Contributor

@mohvn mohvn commented Apr 19, 2024

This PR integrates wordlists of 200, 1000, and advanced Portuguese words. This will significantly expand the variety of words available to users, promoting a more diverse and challenging typing experience.

@mohvn mohvn changed the title feat: add wordlists of portuguese with 200, 1000 lines and advanced… add: wordlists of portuguese with 200, 1000 lines and advanced… Apr 19, 2024
Copy link
Copy Markdown
Owner

@max-niederman max-niederman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind adding these to the table of languages in the readme?

@mohvn
Copy link
Copy Markdown
Contributor Author

mohvn commented Apr 19, 2024

Would you mind adding these to the table of languages in the readme?

Absolutely! I'll get that done right away

Copy link
Copy Markdown
Owner

@max-niederman max-niederman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, one other thing. I didn't notice this before, but you're using portuguese_advanced wheras we're currently using hyphens for existing language variants. Could you just rename the file to use hyphens real quick?

@mohvn
Copy link
Copy Markdown
Contributor Author

mohvn commented Apr 19, 2024

Oh, one other thing. I didn't notice this before, but you're using portuguese_advanced wheras we're currently using hyphens for existing language variants. Could you just rename the file to use hyphens real quick?

Done 👍

@mohvn
Copy link
Copy Markdown
Contributor Author

mohvn commented Apr 24, 2024

Do I need to do anything else to get this PR to be merged? 🤔

Copy link
Copy Markdown
Owner

@max-niederman max-niederman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about that! I just forgot.

@max-niederman max-niederman merged commit 333b123 into max-niederman:main Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants